Export VisualTestAppContext on Windows under test-support - #95
Merged
Merged
Conversation
Advance the pinned GPUI fork so TestGpuixRenderer can use VisualTestAppContext with the Windows test-support platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full-matrix run (33064950701) failed the x86_64-pc-windows-msvc build with three E0433/E0425 'cannot find VisualTestAppContext in gpui' errors: gpui's visual_test_context module and its re-export were cfg-gated to macOS, while #78's re-enabled Windows path (and #89's test-context draw changes) reference it. The zed commit compiles the module and re-export under test-support on macOS or Windows, matching gpui_platform/test-support which already enables gpui_windows/test-support. No gpuix cfg workaround needed. macOS verification local (471 pass / 18 skip + 41 examples); Windows compilation proof is the re-dispatched matrix build job (host lacks MSVC headers). Zed commit c6d1fd93a0 pushed as the gpuix-w3 tip.
🤖 Generated with Claude Code