fix(native): carry clip ids through the Linux paint surface - #497
Merged
Merged
Conversation
Moves the zed submodule to Ernxst/zed fix/linux-paint-surface-clip-id. paint_surface records the current clip id instead of a content mask, and gpui_wgpu resolves that id against the scene's clip nodes, which restores the Linux and FreeBSD build after the clip-node and wgpu-compositing changes crossed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeLg4hAoSTfk74kTf2r4iY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harness: Claude Code
Agent: none
Model: anthropic/claude-opus-5
Task statements
List the small open issues that remain. (Working-directory and workflow instructions omitted.)
Leave the two canvas WPT issues out, as they are reserved. (Working-directory and workflow instructions omitted.)
Fix the reduced-motion example test flake and close the unreproducible screenshot drift issue. (Working-directory and workflow instructions omitted.)
Identify the next smallest issue. (Working-directory and workflow instructions omitted.)
Carry out the tick-starvation measurement, keeping the scale-transform issue open for a later effort estimate. (Working-directory and workflow instructions omitted.)
Close the release-automation and GPU-test tracking issues, and discuss the stacking-order issue's scope. (Working-directory and workflow instructions omitted.)
Measure the Linux bundle size and profile the scroll-redraw issue; fix the submodule breakage found on the way. (Working-directory and workflow instructions omitted.)
Moves the zed submodule to
Ernxst/zedfix/linux-paint-surface-clip-id, which repairs the Linux and FreeBSD build.The scene clip-node change replaced per-primitive content masks with clip ids. The wgpu compositing path, merged later, was still written against the old shape:
gpui'spaint_surfacenow recordscurrent_clip_id()like every other primitive, andgpui_wgpu'sdraw_surfacesresolves that id to the clip node'sfolded_bounds, falling back to the surface's own bounds when no node applies.Before this, a Linux target check failed at the struct literal:
cargo check --target x86_64-unknown-linux-gnu --no-default-features --all-targetsgpui, then ingpui_wgpucargo check --all-targets(host, macOS)macOS and Windows were never affected: the surface path is gated to Linux and FreeBSD. CI builds Linux only on manual dispatch, and the last dispatch predates the merge that introduced this, which is why it went unnoticed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KeLg4hAoSTfk74kTf2r4iY