fix: add provider auth to add_continuous_balance (#45) - #46
Open
leanworld7-netizen wants to merge 1 commit into
Open
fix: add provider auth to add_continuous_balance (#45)#46leanworld7-netizen wants to merge 1 commit into
leanworld7-netizen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #45: add_continuous_balance zero auth
Changes
Added flow.provider.require_auth() to add_continuous_balance before calling add_balance_to_flow.
Root Cause
add_continuous_balance (L5506) delegates to add_balance_to_flow (L2817) with no authorization check. Any caller can inflate any stream balance.
Fix
Added provider auth check before the balance addition call:
let flow = get_continuous_flow_or_panic(&env, stream_id);
flow.provider.require_auth();
Severity
CRITICAL - per SECURITY.md section 4.1, Critical = $10K-$50K bounty.
Requesting review from @KarenZita01.