Skip to content

fix: add admin auth to set_legal_vault and collect_streaming_fees (siblings of #38) #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leanworld7-netizen wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add admin auth to set_legal_vault and collect_streaming_fees (siblings of #38) #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6e64f3
fix(#38): add admin auth to set_government_vault and set_tax_rate
leanworld7-netizen Jul 31, 2026
d99dc56
fix: add admin auth to set_legal_vault and collect_streaming_fees
leanworld7-netizen Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 43 additions & 9 deletions contracts/utility_contracts/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6127,9 +6127,17 @@ impl UtilityContract {
);
}

// Task #2: Tax Compliance - Set government vault address
pub fn set_government_vault(env: Env, vault_address: Address) {
vault_address.require_auth();
// Task #2: Tax Compliance - Set government vault address (admin-only)
pub fn set_government_vault(env: Env, admin: Address, vault_address: Address) {
admin.require_auth();
let stored_admin: Address = env
.storage()
.instance()
.get(&DataKey::CurrentAdmin)
.expect("admin not set");
if admin != stored_admin {
panic_with_error!(&env, ContractError::Unauthorized);
}

env.storage()
.instance()
Expand All @@ -6139,9 +6147,17 @@ impl UtilityContract {
.publish((soroban_sdk::symbol_short!("GovVault"),), vault_address);
}

// Task #2: Tax Compliance - Set tax rate (in basis points)
pub fn set_tax_rate(env: Env, tax_rate_bps: i128) {
// Should be admin-only in production
// Task #2: Tax Compliance - Set tax rate (in basis points, admin-only)
pub fn set_tax_rate(env: Env, admin: Address, tax_rate_bps: i128) {
admin.require_auth();
let stored_admin: Address = env
.storage()
.instance()
.get(&DataKey::CurrentAdmin)
.expect("admin not set");
if admin != stored_admin {
panic_with_error!(&env, ContractError::Unauthorized);
}
if tax_rate_bps < 0 || tax_rate_bps > 10_000 {
panic_with_error!(&env, ContractError::InvalidUsageValue);
}
Expand Down Expand Up @@ -6608,8 +6624,16 @@ impl UtilityContract {
}

/// Set legal vault address
pub fn set_legal_vault(env: Env, vault: Address) {
vault.require_auth();
pub fn set_legal_vault(env: Env, admin: Address, vault: Address) {
admin.require_auth();
let stored_admin: Address = env
.storage()
.instance()
.get(&DataKey::CurrentAdmin)
.expect("No admin set");
if admin != stored_admin {
panic_with_error!(&env, ContractError::UnauthorizedAdmin);
}

env.storage().instance().set(&DataKey::LegalVault, &vault);

Expand Down Expand Up @@ -7947,7 +7971,17 @@ impl UtilityContract {

/// Sweep accrued streaming fees for a stream to the Protocol Fee Vault.
/// Anyone can call this; the vault address is set by the admin.
pub fn collect_streaming_fees(env: Env, stream_id: u64) -> i128 {
pub fn collect_streaming_fees(env: Env, admin: Address, stream_id: u64) -> i128 {
admin.require_auth();
let stored_admin: Address = env
.storage()
.instance()
.get(&DataKey::CurrentAdmin)
.expect("No admin set");
if admin != stored_admin {
panic_with_error!(&env, ContractError::UnauthorizedAdmin);
}

let vault: Address = env
.storage()
.instance()
Expand Down