Skip to content

fix(#38): add admin auth to set_government_vault and set_tax_rate #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leanworld7-netizen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(#38): add admin auth to set_government_vault and set_tax_rate #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions contracts/utility_contracts/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6127,9 +6127,17 @@ impl UtilityContract {
);
}

// Task #2: Tax Compliance - Set government vault address
pub fn set_government_vault(env: Env, vault_address: Address) {
vault_address.require_auth();
// Task #2: Tax Compliance - Set government vault address (admin-only)
pub fn set_government_vault(env: Env, admin: Address, vault_address: Address) {
admin.require_auth();
let stored_admin: Address = env
.storage()
.instance()
.get(&DataKey::CurrentAdmin)
.expect("admin not set");
if admin != stored_admin {
panic_with_error!(&env, ContractError::Unauthorized);
}

env.storage()
.instance()
Expand All @@ -6139,9 +6147,17 @@ impl UtilityContract {
.publish((soroban_sdk::symbol_short!("GovVault"),), vault_address);
}

// Task #2: Tax Compliance - Set tax rate (in basis points)
pub fn set_tax_rate(env: Env, tax_rate_bps: i128) {
// Should be admin-only in production
// Task #2: Tax Compliance - Set tax rate (in basis points, admin-only)
pub fn set_tax_rate(env: Env, admin: Address, tax_rate_bps: i128) {
admin.require_auth();
let stored_admin: Address = env
.storage()
.instance()
.get(&DataKey::CurrentAdmin)
.expect("admin not set");
if admin != stored_admin {
panic_with_error!(&env, ContractError::Unauthorized);
}
if tax_rate_bps < 0 || tax_rate_bps > 10_000 {
panic_with_error!(&env, ContractError::InvalidUsageValue);
}
Expand Down