Refactor: Split monolithic index.js into modular Express application … - #35
Open
JinadJay wants to merge 2 commits into
Open
Refactor: Split monolithic index.js into modular Express application …#35JinadJay wants to merge 2 commits into
JinadJay wants to merge 2 commits into
Conversation
…structure - Create src/config/index.js for centralized configuration - Create src/routes/index.js for route aggregation - Create src/services/index.js for service initialization - Create src/app.js for Express app configuration - Create src/server.js for HTTP server with graceful shutdown - Update index.js to minimal entry point - Update package.json scripts - Update test imports to use src/app.js - Add unit tests for app.js - Add integration tests for server.js This refactoring improves separation of concerns, testability, and maintainability. The app can now be imported without starting the server, enabling faster tests. Graceful shutdown handling for SIGTERM/SIGINT signals is implemented. Resolves EquipChain#28
Member
|
Failed CI. Try and fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…structure
This refactoring improves separation of concerns, testability, and maintainability. The app can now be imported without starting the server, enabling faster tests. Graceful shutdown handling for SIGTERM/SIGINT signals is implemented.
Resolves #28