refactor(trader): drop user-facing on-chain wording from copy - #103
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #101. Removes user-facing "on-chain" jargon from the trader UI, per the product's first design principle (the chain is plumbing; it's never advertised in the UI). No behavior changes, copy only.
Visible UI
ON-CHAINbecomesVERIFIED(tooltip: "Realized equity is verified; live P&L overlaid").Error / status messages (surfaced to the trader via
serverError)Kept intentionally
NFTlink label on the username card.layout.tsx.Follow-up (not in this PR)
packages/shared/sui-propfirm/src/signer.tsthrows "On-chain call failed", which reaches the trader when a tx aborts. Left out because it's in the shared package used by the executor service too. Can add it here on request.Verified:
tsc --noEmitclean, 120/120 tests pass.