Skip to content

refactor(trader): drop user-facing on-chain wording from copy - #103

Merged
Gift-Stack merged 2 commits into
mainfrom
claude/remove-onchain-wording
Jul 2, 2026
Merged

Gift-Stack merged 2 commits into
mainfrom
claude/remove-onchain-wording

Conversation

@Gift-Stack

Copy link
Copy Markdown
Contributor

Stacked on #101. Removes user-facing "on-chain" jargon from the trader UI, per the product's first design principle (the chain is plumbing; it's never advertised in the UI). No behavior changes, copy only.

Visible UI

  • EvaluationCockpit: the equity chip ON-CHAIN becomes VERIFIED (tooltip: "Realized equity is verified; live P&L overlaid").
  • HeroRail: "tracked on-chain" becomes "tracked and independently verifiable".
  • CohortSpotlight: heading "A closed-beta prop evaluation on-chain" becomes "A closed-beta prop evaluation".
  • StartPageClient: "your on-chain evaluation account" becomes "your evaluation account".
  • TradeIntentForm: "Account suspended on-chain" becomes "Account suspended" (and the sibling disabled reasons drop the em dashes).
  • CreateAccountFlow: "recorded on-chain and can't be altered" becomes "recorded and can't be altered".

Error / status messages (surfaced to the trader via serverError)

  • API route fallbacks (positions/open, trades/close, evaluation pass + fail, reactivate, breach), onboarding payment errors, the account-id error, and the tier-read errors all drop "on-chain".
  • Username claim/pending messages drop "on-chain" and switch "mint" to "claim" to match the Claim button.

Kept intentionally

  • The NFT link label on the username card.
  • OG metadata alt text in layout.tsx.
  • Developer log strings and code comments (dev/ops facing, where "on-chain" is meaningful).

Follow-up (not in this PR)

packages/shared/sui-propfirm/src/signer.ts throws "On-chain call failed", which reaches the trader when a tx aborts. Left out because it's in the shared package used by the executor service too. Can add it here on request.

Verified: tsc --noEmit clean, 120/120 tests pass.

@vercel

vercel Bot commented Jul 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ultraprop Ready Ready Preview, Comment Jul 2, 2026 4:11pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
ultraprop-docs Skipped Skipped Jul 2, 2026 4:11pm
ultraprop-website Skipped Skipped Jul 2, 2026 4:11pm

Base automatically changed from claude/dazzling-jemison-36a990 to main July 2, 2026 16:06
@vercel
vercel Bot temporarily deployed to Preview – ultraprop-docs July 2, 2026 16:08 Inactive
@vercel
vercel Bot temporarily deployed to Preview – ultraprop-website July 2, 2026 16:08 Inactive
@Gift-Stack
Gift-Stack merged commit caec2c0 into main Jul 2, 2026
6 checks passed
@Gift-Stack
Gift-Stack deleted the claude/remove-onchain-wording branch July 2, 2026 16:12

This branch was successfully deployed

1 active and 2 inactive deployments
Preview – ultraprop — 7d77e20e Deployed Jul 2, 2026 by vercel[bot]
Preview – ultraprop-website — 7d77e20e Deployed Jul 2, 2026 by vercel[bot]
Preview – ultraprop-docs — 7d77e20e Deployed Jul 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant