Fix setText failing because using incorrect WebView API #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setText is not working because in this commit Enough-Software@fb99d59 the API used to load HTML has been changed from `loadHtmlString` to `evaluateJavascript` instead of `loadData`. It raises errors like this one because we send HTML string to JS handler : `Uncaught SyntaxError: Unexpected token '<'`
zatteo
added a commit
to linagora/tmail-flutter
that referenced
this pull request
Jan 15, 2026
To be complete, this fix needs this PR Enough-Software/enough_html_editor#37
Contributor
|
Is there a detailed video demonstrating how to reproduce this error? |
zatteo
added a commit
to linagora/tmail-flutter
that referenced
this pull request
Jan 16, 2026
- Fix Scribe replace on mobile when opened from menu bar (to be complete this fix needs this PR Enough-Software/enough_html_editor#37) - Ensure all mobile editor call are awaited - Do not clear text if a selection has been restored (which mean we replace a selection) - Avoid collapseToEnd crash
Author
I updated the description to add a way to reproduce and two videos. |
dab246
approved these changes
Feb 2, 2026
zatteo
added a commit
to linagora/tmail-flutter
that referenced
this pull request
Feb 2, 2026
- Fix Scribe replace on mobile when opened from menu bar (to be complete this fix needs this PR Enough-Software/enough_html_editor#37) - Ensure all mobile editor call are awaited - Do not clear text if a selection has been restored (which mean we replace a selection) - Avoid collapseToEnd crash
zatteo
added a commit
to linagora/tmail-flutter
that referenced
this pull request
Feb 2, 2026
- Fix Scribe replace on mobile when opened from menu bar (to be complete this fix needs this PR Enough-Software/enough_html_editor#37) - Ensure all mobile editor call are awaited - Do not clear text if a selection has been restored (which mean we replace a selection) - Avoid collapseToEnd crash
hoangdat
pushed a commit
to linagora/tmail-flutter
that referenced
this pull request
Feb 2, 2026
- Fix Scribe replace on mobile when opened from menu bar (to be complete this fix needs this PR Enough-Software/enough_html_editor#37) - Ensure all mobile editor call are awaited - Do not clear text if a selection has been restored (which mean we replace a selection) - Avoid collapseToEnd crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @robert-virkus and thank you for the work.
setText is not working because in this commit fb99d59 the API used to load HTML has been changed from
loadHtmlStringtoevaluateJavascriptinstead ofloadData.It raises errors like this one below because we send HTML string to JS handler.
Uncaught SyntaxError: Unexpected token '<'To reproduce
Use example app (using Flutter 3.16.0 and Java 11 for me) and add in
example/lib/main.dartat line 102:Before
Screen.Recording.2026-01-19.at.10.38.53.mov
After
Screen.Recording.2026-01-19.at.10.39.32.mov