Fix main CI: Prettier 3.9.8 formatting and Node 22.19 floor - #40
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
undici 8 declares node >=22.19.0 and crashes on import under Node 20, so CI's Node 20 job fails on main. Raise the engine range, test on 22 and 24, and update the contributor guide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
data-angel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
mainfails for two reasons, both older than any open PR.bin/lloom.mjs,src/cluster.mjs,src/config-profiles.mjs,src/host-memory.mjs,test/config-profiles.test.mjsandtest/openrouter-provider.test.mjs. Fixed by runningnpm run format, with no other changes to them.node >=22.19.0and crashes on import under Node 20 (webidl.util.markAsUncloneable is not a function). The engine range now says>=22.19.0, CI tests Node 22 and 24, and CONTRIBUTING and the changelog are updated. All Spark hosts already run 22.19.0.Test plan
check,format:check,lint,npm test,interchange:check,npm audit --audit-level=high,package:check. All pass.🤖 Generated with Claude Code