Skip to content

fix(lib-q-ml-dsa, lib-q-ml-kem): stop forcing std through no_std dependency edges #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nexlab-One merged 2 commits into from
Sep 20, 2026
Merged

fix(lib-q-ml-dsa, lib-q-ml-kem): stop forcing std through no_std dependency edges #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c5d904
fix(ml-dsa): drop the redundant hex dependency that forced std on no_…
Xtrem-e Aug 20, 2026
c96add6
fix(lib-q-ml-dsa, lib-q-ml-kem): stop forcing std through no_std depe…
Xtrem-e Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions lib-q-ml-dsa/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,20 @@ ignored = [
bench = false

[dependencies]
lib-q-ring = { path = "../lib-q-ring", version = "0.0.11", default-features = false, features = ["std"] }
lib-q-sha3 = { path = "../lib-q-sha3", version = "0.0.11" }
lib-q-intrinsics = { path = "../lib-q-intrinsics", version = "0.0.11" }
lib-q-platform = { path = "../lib-q-platform", version = "0.0.11" }
lib-q-keccak = { path = "../lib-q-keccak", version = "0.0.11", features = ["simd"] }
lib-q-random = { path = "../lib-q-random", version = "0.0.11", optional = true }
lib-q-ring = { path = "../lib-q-ring", version = "0.0.11", default-features = false, features = ["alloc"] }
lib-q-sha3 = { path = "../lib-q-sha3", version = "0.0.11", default-features = false, features = ["alloc"] }
lib-q-intrinsics = { path = "../lib-q-intrinsics", version = "0.0.11", default-features = false }
lib-q-platform = { path = "../lib-q-platform", version = "0.0.11", default-features = false }
lib-q-keccak = { path = "../lib-q-keccak", version = "0.0.11", default-features = false, features = ["simd"] }
lib-q-random = { path = "../lib-q-random", version = "0.0.11", optional = true, default-features = false, features = ["alloc"] }
hax-lib.workspace = true
hex = { workspace = true }
# `hex` is deliberately NOT a normal dependency: it is used only by this crate's tests
# (wycheproof, nistkats, acvp, wire_format, avx2_independent_verify) and is already declared
# in [dev-dependencies] below. The redundant entry here was unconditional and non-optional,
# and `hex` does not declare #![no_std] unless its own `std` feature is off -- so it forced
# std into every no_std consumer of this crate, which is what broke GIP's
# `cargo check -p gip-packet --target thumbv7em-none-eabihf` build. Zero `hex::` uses exist
# anywhere under src/, so removing it changes no compiled code.
zeroize = { workspace = true, optional = true }
subtle = { workspace = true, optional = true }
getrandom = { workspace = true, optional = true, default-features = false }
Expand Down Expand Up @@ -97,10 +103,10 @@ simd128 = ["lib-q-sha3/asm", "lib-q-intrinsics/simd128"] # ARM NEON optimizatio
simd256 = ["lib-q-sha3/asm", "lib-q-keccak/std", "lib-q-intrinsics/simd256"] # x86_64 AVX2 optimizations

# Standard library support
std = []
std = ["lib-q-ring/std", "lib-q-sha3/std", "lib-q-intrinsics/std", "lib-q-platform/std", "lib-q-random?/std"]

# Random number generation
random = ["dep:lib-q-random", "lib-q-random/std"]
random = ["dep:lib-q-random", "lib-q-random/alloc"]
nist-drbg = ["random", "lib-q-random/nist-drbg"] # NIST SP 800-90A DRBG for KAT compatibility

# Security hardening
Expand Down
8 changes: 4 additions & 4 deletions lib-q-ml-kem/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ ignored = [
]
[features]
default = ["std"]
std = [] # When enabled, the crate is not `#![no_std]` (links `std`, providing the global allocator required by the `cdylib` output). `no_std` consumers must use `default-features = false`.
std = ["lib-q-random?/std"] # When enabled, the crate is not `#![no_std]` (links `std`, providing the global allocator required by the `cdylib` output). `no_std` consumers must use `default-features = false`.
deterministic = [] # Expose deterministic generation and encapsulation functions
random = ["dep:lib-q-random", "lib-q-random/std"]
random = ["dep:lib-q-random", "lib-q-random/alloc"]
# JS/WASM bindings handle decapsulation keys and shared secrets; the `zeroize` crate is always linked for safe memory hygiene on the Rust side of the boundary.
wasm = [
"wasm-bindgen",
Expand All @@ -50,7 +50,7 @@ pkcs8 = ["dep:der"]
hybrid-array = { workspace = true, features = ["extra-sizes"] }
rand_core = { workspace = true }
lib-q-sha3 = { path = "../lib-q-sha3", version = "0.0.11" }
lib-q-random = { path = "../lib-q-random", version = "0.0.11", optional = true }
lib-q-random = { path = "../lib-q-random", version = "0.0.11", optional = true, default-features = false }
zeroize = { workspace = true, default-features = false, features = ["alloc"] }
subtle = { workspace = true, default-features = false }
getrandom = { workspace = true, optional = true, default-features = false }
Expand Down Expand Up @@ -78,7 +78,7 @@ crate-type = ["cdylib", "rlib"]
[package.metadata.wasm-pack.profile.release]
wasm-opt = ["-Oz", "--enable-bulk-memory"]

[dev-dependencies]
[target.'cfg(not(target_os = "none"))'.dev-dependencies]
# Conformance test only: `lib-q-types` holds the sizes `lib-q-core::SecurityConstants` reads;
# this crate asserts its own real computed sizes match, so drift fails CI on either side.
lib-q-types = { path = "../lib-q-types", version = "0.0.11", default-features = false }
Expand Down
Loading