Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore explicit typed
Grab*proposal snapshots while keeping the automatic path-reference ownership from ydb-platform/ydb#46343. This comparison draft is based on that PR's96311a46096head, so the diff isolates the alternative.TDbRefMapnow acquires references on insertion and releases them on erasure without importingTMemoryChanges, accepting a transaction argument, or checking proposal phases. Proposal callers useGrabNew*before insertion and typedGrab*before snapshot-backed mutation or replacement. The memory-change coordinator keeps typed snapshots and remaining field undo in a common stack, preserving reverse mutation order. Membership restoration bypasses reference accounting becausePathshas already restored the counters.Snapshots restore into the original info object to preserve owning aliases. Table snapshots use
DeepCopyand rebuild their internal partition pointers on restoration. Full table snapshots therefore cost time and memory proportional to partition/statistics state;Updateitself remains a lookup. Types without an existing whole-object snapshot implementation retain explicit field undo. Undo registration outside a proposal now aborts instead of silently discarding the action.Set({..., .Changes = ...})GrabNew*thenSet(id, value)Restoring the table object's identity does not preserve addresses of individual partition/statistics entries across full snapshot restoration. The new regressions replace the original partition storage, check restored values and TTL aliases, and exercise repeated snapshots. Existing reference-count, undo-order, redo-abort, and TTL tests remain.
Validation:
git diff --checkpassed. This final implementation has not been built or tested, as requested; remote validation is pending. An earlier local build attempt was interrupted before any tests ran.Run the complete SchemeShard test tree from the repository root (tests include the build):
For a smaller first pass covering the ownership regressions, proposal redo rollback, and TTL aliases: