Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Enjection
changed the base branch from
draft/schemeshard-tpathref
to
draft/schemeshard-mutation-snapshots-base
September 7, 2026 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog entry
Deferred SchemeShard automatic mutation-snapshot prototype; not for release.
Description for reviewers
Extract the automatic object snapshots, rollback restoration, and partitioning CoW prototype from upstream #46343. This draft uses a fixed base at the reduced ownership commit (
fe39a0b), so its diff contains only the deferred layer and its tests while the upstream PR advances withmain.Intentionally not ready to merge: whole-table snapshots still copy per-shard statistics even with CoW partitioning, which is costly for tables with 200,000+ shards. A scalable mutation/rollback design needs separate review; this prototype is not MVCC.
Verification:
ut_base,ut_ttl, andut_split_mergepassed locally withhya make -T --build=relwithdebinfo -ttt: 3 suites, 444/444 tests. The tested source tree exactly matches this draft's head.