Fix authentication URL port handling#75
Open
maci3jka wants to merge 1 commit into
Open
Conversation
Contributor
|
Please rebase; CI should pass at f1ab63d |
a3376bc to
91892ce
Compare
Author
@laszlocsomor done |
Contributor
|
And please describe in the PR message what was the bug. Looks like when the cluster listens on a nonstandard port, the verification URL should contain it too, but please confirm. When would this be a problem, I mean in what case do you access a cluster on a nonstandard port? |
Author
|
I've faced $engflow_auth login --insecure localhost:8443
Warning: server TLS validation is disabled
Attempting to automaticaly open the authentication URL in your web browser.
If the browser does not open or you wish to use a different device to authorize this request, open the following URL:
https://localhost/login?userCode=XXXX-YYYY-ZZZZ&redirect=QWERTY123==this pr fixes that. I've updated the description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the cluster URL includes a non-default port (non 443) and the verification URL does not specify one, the browser was opened to the wrong host — missing the port entirely and causing the authentication flow to fail.
Example that I faced when port forwarding k8s service