Skip to content

Fix authentication URL port handling#75

Open
maci3jka wants to merge 1 commit into
EngFlow:mainfrom
maci3jka:authentication_URL_port_fix
Open

Fix authentication URL port handling#75
maci3jka wants to merge 1 commit into
EngFlow:mainfrom
maci3jka:authentication_URL_port_fix

Conversation

@maci3jka
Copy link
Copy Markdown

@maci3jka maci3jka commented May 11, 2026

When the cluster URL includes a non-default port (non 443) and the verification URL does not specify one, the browser was opened to the wrong host — missing the port entirely and causing the authentication flow to fail.
Example that I faced when port forwarding k8s service

$engflow_auth login --insecure localhost:8443
Warning: server TLS validation is disabled
Attempting to automaticaly open the authentication URL in your web browser.
If the browser does not open or you wish to use a different device to authorize this request, open the following URL:

        https://localhost/login?userCode=XXXX-YYYY-ZZZZ&redirect=QWERTY123==

@laszlocsomor
Copy link
Copy Markdown
Contributor

laszlocsomor commented May 13, 2026

Please rebase; CI should pass at f1ab63d

@maci3jka maci3jka force-pushed the authentication_URL_port_fix branch from a3376bc to 91892ce Compare May 13, 2026 19:34
@maci3jka
Copy link
Copy Markdown
Author

Please rebase; CI should pass at f1ab63d

@laszlocsomor done

@laszlocsomor
Copy link
Copy Markdown
Contributor

And please describe in the PR message what was the bug. Looks like when the cluster listens on a nonstandard port, the verification URL should contain it too, but please confirm.

When would this be a problem, I mean in what case do you access a cluster on a nonstandard port?

@maci3jka
Copy link
Copy Markdown
Author

I've faced

$engflow_auth login --insecure localhost:8443
Warning: server TLS validation is disabled
Attempting to automaticaly open the authentication URL in your web browser.
If the browser does not open or you wish to use a different device to authorize this request, open the following URL:

        https://localhost/login?userCode=XXXX-YYYY-ZZZZ&redirect=QWERTY123==

this pr fixes that. I've updated the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants