75 notebooks

[dalonsoa]

Description

Update the capacity notebook to account for the new output file structure - which is far from ideal from the processing perspective. Performance-wise, there are vectorised options that are faster than apply, but this one was more readable.

The output plot is:

Close #75

Type of change

• Documentation (non-breaking change that adds or improves the documentation)
• New feature (non-breaking change which adds functionality)
• Optimization (non-breaking, back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (whatever its nature)

Key checklist

• All tests pass (eg. python -m pytest)
• Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added or an issue has been opened to tackle that in the future.
  (Indicate issue here: # (issue))

[dalonsoa]

The latest MUSE2 release uses the old file structure, so those tests are failing - but it is for a known reason.

[dc2917]

Seems reasonable to me!

is far from ideal from the processing perspective. Performance-wise, there are vectorised options that are faster than apply, but this one was more readable.

I think for a notebook this sounds like a good approach.

[dalonsoa]

This is the vectorised version, by the way:

# Try merging on asset_id first, then fall back to group_id for unmatched rows
merged = asset_capacities.merge(
    assets[["asset_id", "agent_id", "process_id", "commission_year"]],
    on="asset_id",
    how="left"
)

# Fill in rows where asset_id was None using group_id
mask = merged["agent_id"].isna()
fallback = asset_capacities[mask].merge(
    assets[["group_id", "agent_id", "process_id", "commission_year"]],
    on="group_id",
    how="left"
)

merged.loc[mask, ["agent_id", "process_id", "commission_year"]] = fallback[["agent_id", "process_id", "commission_year"]].values
asset_capacities = merged

[dc2917]

This is the vectorised version, by the way:

Yeah, it's not that it's unclear, but it does make the process look more cumbersome, even if it's less work for the computer to do. I guess it depends on the purpose of the notebook?