Fix missing 26.50 blocks and connected shapes on older servers - #52
Open
TheNINJALLO wants to merge 1 commit into
Open
TheNINJALLO wants to merge 1 commit into
TheNINJALLO wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Minecraft 26.50 adds corner and connection properties to existing block states. On 26.40-26.45 servers, the old hashes make stairs, fences, panes, bars, and tripwire disappear for 26.50 clients. Translating only the packet schema does not repair these values, and mapping every block to its default new state leaves stair corners and connected blocks with the wrong shape.
Changes
Based on current main (
bf707a6, 0.5.1), using its pinned bedrock-protocol 0.3.0. World lookups are scoped to one packet, so cached translators do not retain world or connection state.Validation
manylinux_2_28_x86_64.