Skip to content

fix(types): define and implement the flow typing model #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lewis6991 wants to merge 1 commit into
base: main
Choose a base branch
from
+7,389 −1,628
Draft

fix(types): define and implement the flow typing model #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/emmylua_code_analysis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# EmmyLua Code Analysis

EmmyLua Code Analysis is a static analysis tool for Lua code. It can be used to analyze Lua code and provide code completion, type checking, and other features in IDEs.

See the [flow typing contract](../../docs/emmylua_code_analysis/flow-typing.md) for supported flow features and scope limits.
650 changes: 111 additions & 539 deletions crates/emmylua_code_analysis/src/check/checker/assign_type_mismatch.rs
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 4 additions & 3 deletions crates/emmylua_code_analysis/src/check/checker/attribute_check.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use emmylua_parser::{
use crate::DiagnosticCode;
use crate::semantic_model::SemanticModel;
use crate::semantic_model::type_check;
use crate::semantic_model::type_check::{TypeCheckFailReason, check_type_detail};
use crate::semantic_model::type_check::check_type_detail;
use crate::{LuaFunctionType, LuaType, LuaTypeDeclId, TypeDef};

use super::{CheckContext, Checker};
Expand Down Expand Up @@ -275,8 +275,9 @@ fn add_type_check_diagnostic(
param_type: &LuaType,
) {
let reason = match check_type_detail(semantic_model, arg_type, param_type) {
Err(TypeCheckFailReason::TypeNotMatchWithReason(reason)) => format!(" {reason}"),
Err(TypeCheckFailReason::TypeNotMatch) => String::new(),
Err(err) if err.is_type_not_match() => err
.reason()
.map_or(String::new(), |reason| format!(" {reason}")),
_ => return,
};
context.add_diagnostic(
Expand Down
Loading
Loading