Repository navigation
Verification only: Opus review fixes for upstream PR 21 - #3
ElliotDrel wants to merge 6 commits into
Conversation
…rols Keep hidden and inert background subtrees out of dialog snapshots without dropping reachable offscreen controls. Preserve global actionable indices across bounded pages and expose scope, totals, and continuation in both native backends. Add real Chromium regression coverage, malformed-option tests, Rust formatter coverage, native e2e checks, and CI/documentation updates. Fixes munimtechnologies#18.
Wait for an expected visible CSS selector on state-returning actions or read-only snapshots instead of treating a loaded tab as application readiness. Preserve action success separately from readiness met, timeout, error, or not_requested. Forward the contract and render status consistently in Rust and Swift, with site-policy checks on every observation. Add a real Chromium regression proven to fail on deb4c7a, delayed-dialog MCP integration checks, contract tests, and safe retry documentation. Verified Windows and Linux Rust suites, 16 full browser integration checks, extension/build tests, and tool schema parity.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1646abc1df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } catch (error) { | ||
| return outcome("error", { error: error.message || "evaluate failed" }); |
There was a problem hiding this comment.
When browser_navigate, a link click, or form submission starts a cross-document navigation, Chrome can reject Runtime.evaluate while replacing the execution context. Returning readiness: error immediately here stops polling even though the requested selector may appear well before the deadline, making the newly advertised wait unreliable for navigation-triggering actions; transient navigation/context errors should be retried until the timeout, while page-reported selector errors can remain terminal.
Useful? React with 👍 / 👎.
Fork-main CI exposed ENOTEMPTY after all DOM assertions passed. A launcher-only kill left POSIX Chromium children writing to the disposable profile. Own a private process group and terminate it even if the launcher has already exited. Four deterministic regressions were proven failing before the repair; run them in CI. (cherry picked from commit 655fc19)
1 participant
Note
🤖 gpt-6.1-sol responding on behalf of Elliot
Verification only for upstream munimtechnologies#21. Do not merge.
Head:
98606830b5a4e81e436bc5d7fad7be5efeb1077f, including the test-only cleanup follow-up cherry-picked from fork main655fc19132449429da55fd90d04bddc6696ff0f3. Base remains frozen at actual upstreamdeb4c7a5243d2024b7a627a305e0eecc6bab8c7c; independent fork installation/EOF changes are not in this PR. Close without merging after CI completes.