Repository navigation
CI verification for upstream browser-state PR #21 (do not merge) - #2
ElliotDrel wants to merge 4 commits into
Conversation
…rols Keep hidden and inert background subtrees out of dialog snapshots without dropping reachable offscreen controls. Preserve global actionable indices across bounded pages and expose scope, totals, and continuation in both native backends. Add real Chromium regression coverage, malformed-option tests, Rust formatter coverage, native e2e checks, and CI/documentation updates. Fixes munimtechnologies#18.
Wait for an expected visible CSS selector on state-returning actions or read-only snapshots instead of treating a loaded tab as application readiness. Preserve action success separately from readiness met, timeout, error, or not_requested. Forward the contract and render status consistently in Rust and Swift, with site-policy checks on every observation. Add a real Chromium regression proven to fail on deb4c7a, delayed-dialog MCP integration checks, contract tests, and safe retry documentation. Verified Windows and Linux Rust suites, 16 full browser integration checks, extension/build tests, and tool schema parity.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2a466b3d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } catch (error) { | ||
| return outcome("error", { error: error.message || "evaluate failed" }); |
There was a problem hiding this comment.
When browser_navigate or a click starts a full-document navigation, Runtime.evaluate can reject while the old execution context is being destroyed. This catch immediately reports a final readiness error instead of polling until the configured deadline, after which withState immediately snapshots and may fail the whole call or return stale state. Retry transient navigation/context-loss errors within the wait budget while continuing to treat invalid selectors as terminal.
Useful? React with 👍 / 👎.
| // Tag the full selected scope so indices stay global and earlier pages remain | ||
| // actionable when paging an unchanged UI. Only label/serialize this page. | ||
| el.setAttribute('data-cu-idx', String(index)); | ||
| if (index < offset || index >= offset + limit) continue; |
There was a problem hiding this comment.
On a page with more controls than the requested limit, this assigns data-cu-idx to every control even though only the requested page is returned. After the initial 250-element snapshot, browser_click or browser_request_credentials can therefore accept index 250 or higher and act on a control the caller has never observed, whereas the previous implementation left unreturned controls unaddressable. Track which index ranges have actually been exposed and reject actions against unseen indices while preserving previously viewed pages.
Useful? React with 👍 / 👎.
1 participant
Verification-only PR for munimtechnologies#21. Runs the existing identical CI workflow, including Swift build and real-Chrome smoke tests, on f2a466b. Upstream CI requires maintainer approval. No CI policy is bypassed or weakened; this fork run supplies independent platform evidence. Do not merge this verification PR. The fixing PR is upstream munimtechnologies#21.