Skip to content

Add Crafting Current Expansion Only filter for Place Crafter Order window#357

Open
nulltyto wants to merge 1 commit into
EllesmereGaming:mainfrom
nulltyto:feature/filter-crafting-to-current-expansion
Open

Add Crafting Current Expansion Only filter for Place Crafter Order window#357
nulltyto wants to merge 1 commit into
EllesmereGaming:mainfrom
nulltyto:feature/filter-crafting-to-current-expansion

Conversation

@nulltyto
Copy link
Copy Markdown
Contributor

@nulltyto nulltyto commented Jun 1, 2026

Summary

Adds a Crafting Current Expansion Only QoL toggle that mirrors the existing AH Current Expansion Only option, but applies to the Place Crafter Order window (Blizzard_ProfessionsCustomerOrders).

When enabled, the "Current Expansion Only" filter is automatically applied each time the crafter order browse window opens, so searches are scoped to the current expansion without manually toggling the filter.

How it works

The crafter-order browse window reuses the Auction House filter system — its search reads filterDropdown.filters[Enum.AuctionHouseFilter.CurrentExpansionOnly], the same enum the AH feature uses. Each time the window opens, ProfessionsCustomerOrdersBrowsePageMixin:SetDefaultFilters() resets the filter table to defaults.

Since the orders addon is load-on-demand, the new code waits for ADDON_LOADED (or hooks immediately if already loaded), then hooksecurefuncs the live browse page's SetDefaultFilters. After Blizzard resets filters, it re-applies CurrentExpansionOnly = true when the option is enabled. Setting the filter table directly also makes the dropdown checkbox reflect the checked state, matching the AH behavior.

Changes

  • EllesmereUIQoL/EllesmereUIQoL.lua — new runtime block (after the AH block) that hooks the customer orders browse page filters.
  • EllesmereUIQoL/EUI_QoL_Options.lua — added the toggle (split the AH/Talking Head DualRow since it only holds two cells) and a reset-to-defaults entry.

Testing

  • Both files pass luac syntax checks.
  • Verified in-game: enabling the toggle applies the Current Expansion Only filter on the next search after opening the Place Crafter Order window.

…ndow

Mirrors the AH Current Expansion Only QoL toggle. Hooks the customer
orders browse page's SetDefaultFilters to re-apply the CurrentExpansionOnly
filter whenever the Place Crafter Order window opens, when enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant