Add Crafting Current Expansion Only filter for Place Crafter Order window#357
Open
nulltyto wants to merge 1 commit into
Open
Conversation
…ndow Mirrors the AH Current Expansion Only QoL toggle. Hooks the customer orders browse page's SetDefaultFilters to re-apply the CurrentExpansionOnly filter whenever the Place Crafter Order window opens, when enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Crafting Current Expansion Only QoL toggle that mirrors the existing AH Current Expansion Only option, but applies to the Place Crafter Order window (
Blizzard_ProfessionsCustomerOrders).When enabled, the "Current Expansion Only" filter is automatically applied each time the crafter order browse window opens, so searches are scoped to the current expansion without manually toggling the filter.
How it works
The crafter-order browse window reuses the Auction House filter system — its search reads
filterDropdown.filters[Enum.AuctionHouseFilter.CurrentExpansionOnly], the same enum the AH feature uses. Each time the window opens,ProfessionsCustomerOrdersBrowsePageMixin:SetDefaultFilters()resets the filter table to defaults.Since the orders addon is load-on-demand, the new code waits for
ADDON_LOADED(or hooks immediately if already loaded), thenhooksecurefuncs the live browse page'sSetDefaultFilters. After Blizzard resets filters, it re-appliesCurrentExpansionOnly = truewhen the option is enabled. Setting the filter table directly also makes the dropdown checkbox reflect the checked state, matching the AH behavior.Changes
EllesmereUIQoL/EllesmereUIQoL.lua— new runtime block (after the AH block) that hooks the customer orders browse page filters.EllesmereUIQoL/EUI_QoL_Options.lua— added the toggle (split the AH/Talking HeadDualRowsince it only holds two cells) and a reset-to-defaults entry.Testing
luacsyntax checks.