Unit frames: independent left/right/center health and BTB text#351
Open
liamcooper wants to merge 1 commit into
Open
Unit frames: independent left/right/center health and BTB text#351liamcooper wants to merge 1 commit into
liamcooper wants to merge 1 commit into
Conversation
Mini frames keep center-or-sides exclusivity; shared overlay layout reduces duplication and fixes preview width constraints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Health bar and bottom text bar (BTB) text on player, target, and focus can use left, right, and center at the same time. Each slot has its own content, size, color, and X/Y offset.
Mini frames (pet, target-of-target, boss) use center or left/right: center can be used alone, or left and/or right together, but not all three at once.
Refactored duplicated positioning logic into a shared helper and aligned the options preview with live frame truncation.
What changed
Full frames (Frame Display — player / target / focus)
Mini frames (Mini Frame Edit — pet / ToT / boss)
none, left and/or right work as usual.Code quality
ApplyBarOverlayTextPositionsfor health bar and BTB layout.ApplyClassColorload order (nil on frame init).Decisions
Test plan
/reloadperhp