Improve chat session history restore with clickable player links#343
Open
liamcooper wants to merge 1 commit into
Open
Improve chat session history restore with clickable player links#343liamcooper wants to merge 1 commit into
liamcooper wants to merge 1 commit into
Conversation
Persist player metadata and rebuild linked chat lines on reload for whispers, party, guild, raid, channel, and BN messages, with channel-aware frame routing and direction-safe dedupe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single-file change:
EllesmereUIChat/EllesmereUIChat_SessionHistory.lua.Clickable player names (realm chat)
FormatPlayerChatLine,RebuildPlayerMessageOnRestore,PlayerHyperlink) for all captured player-linked types: say, yell, party, guild, officer, raid, channel, whisper (in/out).playerName,rawBody,lineID, andguidso lines can be rebuilt with|Hplayer:links after/reload.CHAT_*_GETtemplates viaApplyChatTemplate, with correct handling for both single-%s(say/yell/whisper) and double-%s(party/guild/raid/channel) formats.BN whispers
bnSenderID,bnPlayerToken,rawBody, andguid; rebuilds|HBNplayer:links on restore.RefreshBNLinksInMessage.bnSenderIDand have no|HBNplayer:link in the stored message.Channel-aware restore
channelName,channelBaseName,zoneChannelID, andchannelIndex.FrameShowsChannelEntrymirrors BlizzardchannelList/zoneChannelListmatching so Trade vs General (and similar) restore to the correct tab.Dedupe and direction
p:CHATTYPE:NAME:payloadandbn:CHATTYPE:ID:payload(incoming/outgoing no longer collapse when body text matches).BuildFrameMessageSet,PlayerLinkedDedupKeysFromStored) uses the same key shape to avoid double-restore after/reload.WHISPER_INFORM,BN_WHISPER_INFORM, etc.) instead of stripping_INFORM.Capture quality
ChatMessageBodyandChatSenderNameresolve body/sender fromlineIDfirst, then event args, so storedrawBody/playerNamematch the displayed line.whisperPlayerNameis still read for backward compatibility.Removed / unchanged behavior
CHAT_MSG_EMOTE,CHAT_MSG_TEXT_EMOTE) and dropped on sanitize.Test plan
/reloadafter/sayand/yell— sender name is clickable/reloadbnSenderID/links are dropped on sanitize (expected)