Eliayazdi week3#3
Open
EliaYazdi wants to merge 5 commits into
Open
Conversation
marianabocoi
reviewed
Oct 9, 2019
marianabocoi
left a comment
marianabocoi
left a comment
There was a problem hiding this comment.
Remove unnecessary code.
Minor comments.
Comment on lines
+78
to
+79
| const todos = await this.read(); | ||
| let list = [todos]; |
There was a problem hiding this comment.
you do not need to read the todos if you have no need for them.
Owner
Author
There was a problem hiding this comment.
@nicevo But if we don't read the list we don't have anything to delete or...?
There was a problem hiding this comment.
below you are saying list =[]; so it does not matter what value it had before.
It is specific for removing all todos.
| @@ -0,0 +1 @@ | |||
| [] No newline at end of file | |||
There was a problem hiding this comment.
there are 2 todo.json why do you think that is ? 😄
Owner
Author
There was a problem hiding this comment.
Ow... I think I committed the list by mistake
|
there is also a conflict with the master branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.