reckless: rust rewrite by daywalker90 · Pull Request #9239 · ElementsProject/lightning

daywalker90 · 2026-06-19T16:48:24Z

Not ready for code review yet, we have not decided on some important aspects. Right now it is a drop-in replacement of the python reckless version.

Should
Fixes: #8439
Fixes: #8761
Fixes: #8775
Fixes: #8776
Fixes: #8794
and should supercede #8630

Key differences:

it is now a plugin only, the only use case to have a standalone binary, that i could come up with, is a broken plugin install where CLN won't start, but if you can call a binary you can uncomment a line in a config, right?
as a consequence, alot of options are no longer necessary and reckless-dir is a proper plugin option now
except for the help we always output json, so no more --json option
the rewrite does not adhere to the reckless schema in all places, e.g. listavailable, an array of strings is just not nice here
a tip function was added to tip plugin authors that have an offer in their manifest.json

vincenzopalazzo

Nice to see that the manifest idea is taking over. Hope you are also using git for versioning, otherwise this would be another good thing to take from https://github.com/coffee-tools/coffee

vincenzopalazzo · 2026-06-19T18:46:40Z

Would be nice to reference the original reference implementation https://coffee-docs.netlify.app/support-coffee

Would be nice to reference the original reference implementation https://coffee-docs.netlify.app/support-coffee

I was planning on giving full credit for the manifest/tip function to coffee in the README. But i want to lock down the functionality first before writing documentation.

to save credit was also good to just include coffee, I do not think there are more features than coffee, we were also supporting ws (palanning to) to support interactive UX inside the web applications

But these days cloning is easy!

daywalker90 · 2026-06-19T18:50:18Z

Nice to see that the manifest idea is taking over. Hope you are also using git for versioning, otherwise this would be another good thing to take from https://github.com/coffee-tools/coffee

If you mean installing a plugin with a git ref then yes, that is supported.

vincenzopalazzo · 2026-06-19T18:53:28Z

If you mean installing a plugin with a git ref then yes, that is supported.

Yeah, otherwise it's insanity! Nice, it would be nice to have two lines that reference coffee because the development died because Blockstream was moving to reckless. Referencing a good idea is what is left in this AI era, where rebuilding is easy

daywalker90 · 2026-07-14T13:24:22Z

~~Some tests will fail for now because of #9283. If we decide not to fix it, i can do a workaround.~~

If the timestamp of the python file does not differ after an update it will load the bytecode of the old version. We remove the pycache to make sure this does not happen. Mostly a test environment issue as in practive the timestamps should always differ.

…rning an error

…e seconds

…sources

…ecision

After ElementsProject@fce9d6e we can now use it. Also fix writing flag options to config file.

The python wrapper only added the repo root to sys.path and ran the bare file stem, so an entrypoint like src/main.py failed with ImportError. Add the entrypoint's own directory to sys.path as well.

A single malformed manifest.json made find_plugin_locs return an error, so every plugin in that source disappeared from listavailable and install. Skip only the plugin whose manifest is invalid, log why, and keep scanning the rest of the source. The plugin is not installed with a default manifest, since that would ignore fields such as installable: false.

…name The lookup key was lowercased but the install directory kept the original case, so uninstall of MyPlug looked for reckless/myplug and failed to find the directory it had just installed.

A python plugin with a package.json at its root was routed to the nodejs installer, so its python dependencies were never installed.

The nodejs installer symlinked the entry file and executed it directly. A javascript entrypoint without a shebang failed to start with 'Exec format error (os error 8)'. Install a #!/bin/sh wrapper that runs the node binary found at install time instead.

The python wrapper embedded the venv and source paths in a shebang and in python string literals. A path with a space broke the shebang (the kernel splits it), and a path with a single quote broke the python source. Both wrappers are now sh scripts that pass every path as a single-quoted argument, so no value is interpolated into code.

The depth-1 filter skipped any directory whose name contained 'archive', so a plugin named archive_backup was silently left out of the source scan. Match the directory name exactly instead.

The uninstall section showed the install command.

The non-unix stub used a bare Result, which is not imported in this module, so the crate did not compile on non-unix targets.

daywalker90 force-pushed the reckless-rs branch 2 times, most recently from 8644166 to 6889d36 Compare June 19, 2026 17:21

vincenzopalazzo reviewed Jun 19, 2026

View reviewed changes

madelinevibes added this to the v26.09 milestone Jun 22, 2026

madelinevibes assigned daywalker90 Jun 22, 2026

daywalker90 force-pushed the reckless-rs branch 3 times, most recently from 6658af8 to f6bbfb5 Compare July 1, 2026 17:09

daywalker90 force-pushed the reckless-rs branch 5 times, most recently from 5833d8b to 853fe7d Compare July 8, 2026 15:34

daywalker90 force-pushed the reckless-rs branch 4 times, most recently from f4513c8 to bf9e3e2 Compare July 14, 2026 12:39

daywalker90 marked this pull request as ready for review July 14, 2026 13:11

daywalker90 requested a review from cdecker as a code owner July 14, 2026 13:11

daywalker90 force-pushed the reckless-rs branch from bf9e3e2 to 2dde507 Compare July 15, 2026 14:59

madelinevibes added the QA Blockstream QA team have reproduced, or a test has been created! Look for the linked PR/Issue label Jul 17, 2026

daywalker90 force-pushed the reckless-rs branch 2 times, most recently from 59f0030 to a0ca360 Compare July 21, 2026 11:04

madelinevibes unassigned daywalker90 Jul 23, 2026

madelinevibes added the Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. label Jul 23, 2026

madelinevibes requested review from ShahanaFarooqui and enaples July 23, 2026 07:59

ScuttoZ and others added 29 commits November 4, 2026 16:46

typo: changed "lintintalled" instances to "listinstalled"

4a7454e

fix repo owner dir removal when removing source

66af7bb

Makefile: add cln-rpc and cln-plugin as dependency of reckless

7b1f71c

tests: add reckless test for update

5439deb

tests: add reckless tests for listinstalled

b33bf34

reckless: listinstalled: check if reckless dir exists instead of retu…

12c8b10

…rning an error

reckless: return error if enable detects plugin is already running

cebd614

reckless: fix update_config_file returning commented option names

c733f3a

reckless: fix unix_timestamp in notification, it was missing the whol…

26e8e70

…e seconds

reckless: replace two unwraps with ok_or_else

af4cc81

reckless: make plugin search case insensitive

8decb24

pytest: add test for reckless_log notification

8426d02

reckless: only attempt to remove source cache after it was found in .…

fae0689

…sources

reckless: use platform specific python outside venv

f0d6114

pytests: fix iso parser in python 3.10 not working with nanosecond pr…

cafd931

…ecision

reckless: improve cli help texts

b407c4d

reckless: use .call_typed when starting a plugin with options

bf806f3

After ElementsProject@fce9d6e we can now use it. Also fix writing flag options to config file.

reckless: add tests for option persistence

bd69f2e

reckless: fix ListconfigsConfigs no longer being an option

1d8151d

reckless: support plugin entrypoints in subdirectories

cc13752

The python wrapper only added the repo root to sys.path and ran the bare file stem, so an entrypoint like src/main.py failed with ImportError. Add the entrypoint's own directory to sys.path as well.

reckless: store mixed-case plugin directories under their normalized …

c335c3f

…name The lookup key was lowercased but the install directory kept the original case, so uninstall of MyPlug looked for reckless/myplug and failed to find the directory it had just installed.

reckless: detect python entrypoints before package.json

4362bf7

A python plugin with a package.json at its root was routed to the nodejs installer, so its python dependencies were never installed.

reckless: only skip the archived directory by exact name

c896d95

The depth-1 filter skipped any directory whose name contained 'archive', so a plugin named archive_backup was silently left out of the source scan. Match the directory name exactly instead.

docs: fix reckless uninstall example in README

ac25c52

The uninstall section showed the install command.

reckless: fix non-unix set_executable return type

95ed526

The non-unix stub used a bare Result, which is not imported in this module, so the crate did not compile on non-unix targets.

daywalker90 force-pushed the reckless-rs branch from d02ca7b to 95ed526 Compare November 4, 2026 15:46

Navigation Menu

Repository navigation

reckless: rust rewrite - #9239

reckless: rust rewrite#9239
daywalker90 wants to merge 30 commits into
ElementsProject:masterfrom
daywalker90:reckless-rs

daywalker90 commented Jun 19, 2026

Uh oh!

vincenzopalazzo left a comment

Uh oh!

vincenzopalazzo Jun 19, 2026

Uh oh!

daywalker90 Jun 19, 2026

Uh oh!

vincenzopalazzo Jun 19, 2026

Uh oh!

daywalker90 commented Jun 19, 2026

Uh oh!

vincenzopalazzo commented Jun 19, 2026

Uh oh!

daywalker90 commented Jul 14, 2026 •

edited

Loading

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

daywalker90 commented Jun 19, 2026

Uh oh!

vincenzopalazzo left a comment

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

daywalker90 Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

vincenzopalazzo Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

daywalker90 commented Jun 19, 2026

Uh oh!

vincenzopalazzo commented Jun 19, 2026

Uh oh!

daywalker90 commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daywalker90 commented Jul 14, 2026 •

edited

Loading