Open
Conversation
Contributor
|
You can accomplish the same effect via listener: @EventHandler(priority = EventPriority.LOWEST, ignoreCancelled = true)
public void removeDisabledRecipe(PrepareItemCraftEvent event) {
CraftingInventory crafting = event.getInventory();
ItemStack result = crafting.getResult();
if (result == null) return;
if (disabledRecipes.matches(result)) crafting.setResult(null);
}where |
Author
It felt like it would make sense for there to be a way to remove recipes if you can add some. |
Contributor
|
Modern versions have better ways of handling these, but if the api isn't going to be compatible anyways there's little point in adding a method in the older software, i don't think anyone will benefit from adding this except for the added maintenance burden to a version that is already struggling to get maintained. Just do it via event, it works all the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
removeRecipemethods toorg.bukkit.Bukkit,org.bukkit.Server, andorg.bukkit.World.This is mostly useful for removing Vanilla recipes like this: