Open
Conversation
Eldar1205
requested changes
Feb 8, 2023
Owner
Eldar1205
left a comment
Eldar1205
left a comment
There was a problem hiding this comment.
Thank you very much for the contribution, really appreciated!
I've reviewed the changes and provided feedback.
FYI I would like to add a more organized approach to crediting contributors so I recommend to wait with merging this PR until that point.
Author
|
Hi, made the following changes as I was asked:
|
Eldar1205
reviewed
Feb 10, 2023
Owner
Eldar1205
left a comment
Eldar1205
left a comment
There was a problem hiding this comment.
Thanks for handling previous comments!
| 9. <u>Json</u> - fast library for working with JSON, supports dataclasses serialization - [_orjson_](https://github.com/ijl/orjson) | ||
| 10. <u>Data Models</u> - represent system entities as typed data models designed for static type checks - [_pydantic_](https://pydantic-docs.helpmanual.io/): | ||
| 7. <u>Web Scraping</u> - Using code to extract content and data from a website | ||
| 1. Selenium - Selenium Python bindings provides a simple API to write functional and **interactive** tests using Selenium WebDriver [_Docs reference_](https://selenium-python.readthedocs.io/) |
Owner
There was a problem hiding this comment.
Can you please explain how Selenium is usable in the context of web scraping and not just testing?
Eldar1205
reviewed
Feb 10, 2023
Eldar1205
reviewed
Feb 11, 2023
| * Recommended _httpx_ for richer feature set, for web sockets client use [_websockets_](https://websockets.readthedocs.io/en/stable/) | ||
| 15. <u>SQL ORM</u> - object relational mapper for working with SQL databases - [_SQLAlchemy_](https://www.sqlalchemy.org/) | ||
| * Recommended _httpx_ for richer feature set, for web sockets client use [_websockets_](https://websockets.readthedocs.io/en/stable/) | ||
| 3. ([Contributed by HomiGrotas](https://github.com/HomiGrotas)) Requests - The requests module allows you to send HTTP requests using Python [_Official docs reference_](https://requests.readthedocs.io/en/latest/user/quickstart/)<br>***Note: The requests module is synchronous module and therefore it's not recommended for production code expected to be scalable, but can be useful for other scenarios.** |
Owner
There was a problem hiding this comment.
Suggested change
| 3. ([Contributed by HomiGrotas](https://github.com/HomiGrotas)) Requests - The requests module allows you to send HTTP requests using Python [_Official docs reference_](https://requests.readthedocs.io/en/latest/user/quickstart/)<br>***Note: The requests module is synchronous module and therefore it's not recommended for production code expected to be scalable, but can be useful for other scenarios.** | |
| 3. Requests - The requests module allows you to send HTTP requests using Python [_Official docs reference_](https://requests.readthedocs.io/en/latest/user/quickstart/)<br>***Note: The requests module is synchronous module and therefore it's not recommended for production code expected to be scalable, but can be useful for other scenarios.** |
You may ask the all-contributors bot to add you as contributor instead :)
Eldar1205
approved these changes
Feb 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Eldar!
Hi noticed a networks-web topic was missing, so I added one :)