first - #1
Open
EkzeKutor95 wants to merge 1 commit into
Open
first#1EkzeKutor95 wants to merge 1 commit into
EkzeKutor95 wants to merge 1 commit into
Conversation
ivannizh
approved these changes
Jan 28, 2025
ivannizh
left a comment
ivannizh
left a comment
There was a problem hiding this comment.
Привет!
Хороший код, все работает по ТЗ, принято!
Есть одно небольшое замечание, исправь, пожалуйста сам, не буду из-за него возвращать работу.
| // настройте подключение к БД | ||
| db, err := sql.Open("sqlite", "tracker.db") | ||
| if err != nil { | ||
| fmt.Println(err) |
There was a problem hiding this comment.
После вывода ошибки нужно выйти из функции, а иначе код дальше продолжит работу
| storedParcel, err := store.Get(id) | ||
| require.NoError(t, err) | ||
|
|
||
| require.Equal(t, parcel.Client, storedParcel.Client) |
There was a problem hiding this comment.
Функция Equal может сравнивать структуры сразу (а не по полям), надо только с полем Number разобраться.
Нужно переделать, так как при таком подходе при изменении структуры нужно будет менять все тесты
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.