Repository navigation
Fix missed migration for save folder - #858
Open
aidankinzett wants to merge 4 commits into
Open
aidankinzett wants to merge 4 commits into
aidankinzett wants to merge 4 commits into
Conversation
Migration copied the old emulator's config as-is, and configs store data paths as absolute strings, so NAND, SD, saves and the rest kept using the old folder. Rewrite those paths in the migrated ini files instead of the post-migration rename in MainWindow, which no longer matched any folder. Moving the NAND directory in the filesystem settings also left saves kept in the NAND behind; they now follow it. Fixes #813
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
aidankinzett
changed the title
Installs migrated before the config rewrite still use the old emulator's folders, and anything saved since only exists there. At startup, if a data path is inside an old emulator's folder (and it isn't a linked migration), offer to copy it into Eglantine, newer files winning, and switch to it. Declining turns off the check for good.
Clearing the shader cache recreated the shader folder with create_directory, which throws when the Eglantine cache folder doesn't exist yet. It only exists after migration if the old emulator had one, so migrating without it aborted the app.
aidankinzett
force-pushed
the
nx2-exp/migration-paths
branch
from
November 13, 2026 15:16
1ef7ea0 to
c7cb2c7
Compare
Copying the folders still in use into the Eglantine folder kept the newer file, so a profiles.dat that Eglantine created on its own at startup won over the user's real one. The folders in use now always win. Check for free space first, remove whatever was created if the copy fails, show real progress, and stop Escape or the close button from hiding the dialog while the GUI thread waits on the copy. Rewrite migrated configs without throwing on the worker thread, and through a temporary file so a failed write can't truncate them. Ask after the translation is loaded, and don't claim the folders are left over from a migration, since they may be shared on purpose.
aidankinzett
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrating from Eden copied the old config as-is. Configs store data paths as absolute strings, so after migrating, NAND, SD, saves, mods, dumps and TAS kept using the old emulator's folder, and the Eglantine copy went stale.
MainWindow. It replaced the emulator name with "eden", which no longer matches anything after the rename and never covered saves.check_legacy_paths).Type of change
Related issues
Fixes #813
Testing
Games tested:
Not game-specific.
To test: migrate from a legacy
edenfolder with "Keep Old Data" and check that Settings > Filesystem shows Eglantine paths. Then, with an old config still pointing ateden, start the app, accept the prompt, and check that saves made after migrating carried over.Checklist
AI disclosure
I used Claude Opus 5.5 to trace the bug, draft the code and draft this description. I reviewed and tested the changes myself.
Screenshots / logs