Repository navigation
Feature/default execution to new backend - #861
Merged
Merged
Conversation
✅ Deploy Preview for flowfile-wasm canceled.
|
… and app versions and fix notebook visual editor explanation
|
Claude finished @Edwardvaneechoud's task in 28s —— View job Review of #861 (already merged)I read the merged changes and found nothing that needs a follow-up. I only read the code, so I didn't run the test suites. Core change:
Other changes in the PR
Observations
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how the
FLOWFILE_COMPUTE_PROTOCOLenvironment variable is handled in both the documentation and the desktop application setup. The main change is that the desktop shell (env.rs) no longer setsFLOWFILE_COMPUTE_PROTOCOLby default, instead deferring to whatever is set in the launching environment. This allows for more flexible configuration and ensures that the desktop core uses the intended protocol based on user or environment settings.Environment variable handling and documentation updates:
env.rs) no longer explicitly setsFLOWFILE_COMPUTE_PROTOCOLto0when spawning sidecars; it now leaves this variable to be set by the launching environment, allowing the desktop core to use its default unless overridden.CLAUDE.mdfor both the backend and frontend has been updated to accurately describe the new behavior: the desktop shell does not setFLOWFILE_COMPUTE_PROTOCOLby default, and the Flow Settings dialog reflects the current configuration more accurately. [1] [2]