Skip to content

Feature/default execution to new backend - #861

Merged
Edwardvaneechoud merged 4 commits into
mainfrom
feature/default-execution-to-new-backend
Oct 29, 2026
Merged

Edwardvaneechoud merged 4 commits into
mainfrom
feature/default-execution-to-new-backend

Conversation

@Edwardvaneechoud

Copy link
Copy Markdown
Owner

This pull request updates how the FLOWFILE_COMPUTE_PROTOCOL environment variable is handled in both the documentation and the desktop application setup. The main change is that the desktop shell (env.rs) no longer sets FLOWFILE_COMPUTE_PROTOCOL by default, instead deferring to whatever is set in the launching environment. This allows for more flexible configuration and ensures that the desktop core uses the intended protocol based on user or environment settings.

Environment variable handling and documentation updates:

  • The desktop application (env.rs) no longer explicitly sets FLOWFILE_COMPUTE_PROTOCOL to 0 when spawning sidecars; it now leaves this variable to be set by the launching environment, allowing the desktop core to use its default unless overridden.
  • The documentation in CLAUDE.md for both the backend and frontend has been updated to accurately describe the new behavior: the desktop shell does not set FLOWFILE_COMPUTE_PROTOCOL by default, and the Flow Settings dialog reflects the current configuration more accurately. [1] [2]

@netlify

netlify Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for flowfile-wasm canceled.

Name Link
🔨 Latest commit 14ede7c
🔍 Latest deploy log https://app.netlify.com/projects/flowfile-wasm/deploys/6ae327889a452deffa3c9492

… and app versions and fix notebook visual editor explanation
@Edwardvaneechoud
Edwardvaneechoud marked this pull request as ready for review October 29, 2026 13:08
@Edwardvaneechoud
Edwardvaneechoud merged commit 1948be6 into main Oct 29, 2026
60 checks passed
@Edwardvaneechoud
Edwardvaneechoud deleted the feature/default-execution-to-new-backend branch October 29, 2026 13:08
@claude

claude Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Claude finished @Edwardvaneechoud's task in 28s —— View job


Review of #861 (already merged)

I read the merged changes and found nothing that needs a follow-up. I only read the code, so I didn't run the test suites.

Core change: env.rs no longer sets FLOWFILE_COMPUTE_PROTOCOL

  • grep finds no remaining reference to the variable under flowfile_frontend/src-tauri/src, so the removal is complete.
  • The desktop sidecar now takes core's default (protocol on). That matches the CLAUDE.md wording and the worker-embedded design.
  • A user whose launch environment sets FLOWFILE_COMPUTE_PROTOCOL=0 can still switch it off.
  • The two CLAUDE.md edits agree with the code.

Other changes in the PR

  • Image tag parsing (kernel/images.py): parse_image_version now uses PEP 440 (packaging.Version) and returns None for :local and digest tags. flavours._describes_configured_image therefore keeps trusting dev-built images and disowns only a different release. This is what you want, and the unit tests in test_kernel_manager_unit.py and test_kernel_matching_unit.py cover it.
  • Community nodes (community_nodes/models.py): is_version_compatible parses the app version with Version, so 0.24.0-rc.1 still sorts below 0.24.0. A malformed app version returns True (no gating). The code comment on get_app_version explains why that matters.
  • shared/excel_writer.py: the lock design is reasonable. Only contention errnos retry, and other errors fail fast. The update caveats are documented in the module docstring.
  • Docs (notebook.md): I did not fact-check this page.

Observations

  • Scope: the PR description only mentions the env.rs and docs change, but the diff also includes the version-parsing work, the Excel writer, notebook.md and a version bump. Next time, mention the bump and the Excel writer in the description so the changelog is easier to follow.
  • Behaviour change to confirm: desktop users now run the /v1 protocol path by default. The CLAUDE.md text says the shell leaves the variable to the launching environment. An FLOWFILE_COMPUTE_PROTOCOL=0 check would show whether the task-routes fallback still works in a desktop session. I didn't verify that.

This branch was successfully deployed

1 active deployment
pypi — 14ede7cc Deployed Oct 29, 2026 by Edwardvaneechoud via release #109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant