Skip to content

feat(console): support logical TLS worker origins #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EdsonPetry wants to merge 1 commit into from
Draft

feat(console): support logical TLS worker origins #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion console/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ crossterm = "0.29.0"
futures = "0.3.31"
ratatui = "0.30.0"
tokio = { version = "1.49.0", features = ["full"] }
tonic = "0.14.2"
# `tls-ring` turns on the TLS stack; `tls-native-roots` lets `--worker-origin` reach a worker
# whose certificate chains to a CA the machine already trusts, without `--ca-cert`.
tonic = { version = "0.14.2", features = ["tls-ring", "tls-native-roots"] }
# Dialing an address the endpoint URI does not name needs a custom connector.
tower = { version = "0.5.2", features = ["util"] }
hyper-util = { version = "0.1.16", features = ["tokio"] }
datafusion-distributed = { path = "..", features = ["integration", "system-metrics"] }
url = "2.5.7"
tokio-stream = "0.1.18"
Expand Down
11 changes: 6 additions & 5 deletions console/src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,12 @@ impl App {
self.maybe_discover_workers().await;

// Attempt connection for workers in Connecting or Disconnected state
for worker in &mut self.workers {
if worker.should_retry_connection() {
worker.try_connect().await;
}
}
let reconnect_workers = self
.workers
.iter_mut()
.filter(|worker| worker.should_retry_connection())
.map(|worker| worker.try_connect());
futures::future::join_all(reconnect_workers).await;

// Poll all connected workers in parallel with timeout
let poll_workers: Vec<_> = self
Expand Down
Loading