Skip to content

Conversation

@qutaiba
Copy link
Member

@qutaiba qutaiba commented Feb 22, 2022

No description provided.

@qutaiba qutaiba requested a review from a-nassif February 22, 2022 13:10
b2b.css:
docker-compose `echo ${DOCKER_COMPOSE_FILES}` exec b2b npm run scss

b2b.makemessages:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qutaiba I'm not sure we need to makemessages on setup. since the po files are checked in, we just need to compile them to get the compiles mo version. This way every time the setup is run, the po files will appear as changes to be committed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-nassif makemessages is needed on your local setup to collect the new added strings, and po files are required to be committed as mo files are ignored and will not be committed, compilemessages will happen during the deployment

@umar221b
Copy link

umar221b commented Apr 7, 2022

I see 2 other branches that attempt to make changes to make-commands. Can we make all the changes we need/needed in this PR and delete the other 2 branches?
q/make_commands
qutaiba/add-missing-make-commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants