Skip to content

Convert to npm#66

Open
peachbits wants to merge 4 commits into
masterfrom
convert-to-npm
Open

Convert to npm#66
peachbits wants to merge 4 commits into
masterfrom
convert-to-npm

Conversation

@peachbits
Copy link
Copy Markdown
Contributor

@peachbits peachbits commented May 26, 2026

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

Note

Low Risk
Only package-manager and Travis config changes; no runtime or library code in the diff.

Overview
Migrates the repo from Yarn to npm for installs and CI, without changing application source in this diff.

.travis.yml now uses Node 18 only (drops 12), runs npm ci on install, and npm run lint / npm run prepare instead of the Yarn equivalents.

.npmrc is added with legacy-peer-deps=true and ignore-scripts=true (replacing .yarnrc, which is removed).

.gitignore no longer ignores package-lock.json, so the npm lockfile can be tracked.

Reviewed by Cursor Bugbot for commit 49aff36. Bugbot is set up for automated code reviews on this repo. Configure here.

convert-to-npm and others added 3 commits May 26, 2026 14:09
@j0ntz
Copy link
Copy Markdown
Contributor

j0ntz commented Jun 2, 2026

CI status: Travis is red, failing at the install step (Bugbot is clean). Verified from the build log: npm ci crashes with Cannot read property 'biggystring' of undefined because .travis.yml runs node_js: "12" (npm 6), which can't parse lockfileVersion: 3.

Same root cause as EdgeApp/react-native-piratechain#21 — bumping .travis.yml to Node 18 fixes it.

@j0ntz
Copy link
Copy Markdown
Contributor

j0ntz commented Jun 2, 2026

Applied in 49aff36 — bumped .travis.yml node_js from 12 to 18 so the bundled npm can parse lockfileVersion: 3 and npm ci installs. Flagging rather than resolving since this is a change I made on your branch, not yours — please review.

Copy link
Copy Markdown
Contributor

@j0ntz j0ntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — Travis is green after the Node 18 bump. Flagging that this one-line CI change was made by me, so it's worth a quick re-review on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants