Skip to content

Initialize ECC library eagerly so Taproot sends work #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j0ntz wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

Initialize ECC library eagerly so Taproot sends work #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/common/utxobased/keymanager/keymanager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,15 @@ import { InsufficientFundsErrorPlus } from './types'
import * as utxopicker from './utxopicker'
import * as pickerUtils from './utxopicker/utils'

// Eagerly initialize the ECC library at module load. Taproot (p2tr) address
// parsing in `addressToScriptPubkey` (via `payments.p2tr`) requires the ECC
// library, and that code path can run before any ECPair/signing operation
// triggers the lazy `getECPair` init below — e.g. when `makeSpend` converts a
// Taproot recipient address to a scriptPubkey. Without this, sending to a
// `bc1p…` address fails with "No ECC Library provided".
// eslint-disable-next-line @typescript-eslint/no-var-requires
initEccLib(require('@bitcoinerlab/secp256k1'))

let ECPairCache: ECPairAPI
const getECPair = (): ECPairAPI => {
if (ECPairCache != null) return ECPairCache
Expand Down
Loading