Repository navigation
icons: roll out the new edge0 mark to windows and android - #136
Merged
Merged
Conversation
- Regenerate icon.icns / icon.png / edge0_logo.png from the new logo artwork (rounded-square, 1024 master for the icns iconset) - Use the new mark for all four menu-bar tray states (per product decision the states share one glyph; the tray menu text still distinguishes idle/loading/resident/throttled) - Render the new mark in the sidebar brand tile and the welcome card via public/edge0_logo.png, dropping the Sparkles placeholders - Add macos/.gitignore mirroring windows/.gitignore (node_modules, dist, src-tauri target/gen, workspace target, engine build work dir)
- Regenerate icon.ico (16..256 entries, 32bpp) and the full tauri PNG set (icon/edge0_logo, 32/64/128/128@2x, Square*Logo tiles, StoreLogo) from the new mark used by the macos icon set (512 master) - Sync the four tray state PNGs to the new glyph (all states share one mark, same product decision as macos) - Render the new mark in the sidebar brand tile and the welcome card via public/edge0_logo.png, dropping the Sparkles placeholders
- The app shipped with no launcher icon (system default). Add the new mark as per-density legacy mipmaps (mdpi..xxxhdpi) plus an adaptive icon (anydpi-v26: full-bleed artwork over a pure-black background layer), generated from the same 512 master as the macos icon set - Wire android:icon into the manifest. In-app UI is text-only brand headers with standard material icons, so there are no other glyph spots to update on this platform
Chokidar aborts the dev server (EBUSY) while cargo links and Defender locks the fresh artifacts - reproduced twice on a cold `tauri dev` build. The tauri CLI already watches src-tauri for changes itself; this matches the create-tauri-app vite template.
The first set packed the rounded-square mark into the adaptive icon at full bleed, so the launcher's circle mask clipped the lightning tips. Foreground is now the glyph alone (antialiased alpha from the black ground) at ~58% of the canvas, inside the 66% safe zone, over the black background layer; legacy densities take the full-bleed square. Windows icons are untouched per product decision.
The master's glyph now sits at ~58% of the square (was ~64%), so the adaptive foreground inherits the artwork's own padding instead of an extra downscale; legacy densities re-cut from the new image. Verified in a simulated 66% circle-mask render: no tip clipping.
Glyph now sits at ~43.6% of the adaptive canvas (was 58.4%), keeping the mark inside the 66dp safe circle with roomier margins; foreground still inherits the master's own ratio, legacy densities re-cut from the full-bleed square.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes the new edge0 mark rollout on the platforms left after #55a009c
(macos): windows and android app icons, plus every in-app surface that
renders a brand glyph. No artwork changes on the macos side.
Changes
windows (
c0779c9)icon.ico(16..256 entries, 32bpp, same entry set as before),icon.png,edge0_logo.png, MSIX tiles (Square*Logo,StoreLogo),and the four tray state PNGs (states share one glyph, same product
decision as macos; the tray files are currently unused by the shell -
no tray is implemented on windows - synced for consistency)
AppShell.tsx) and welcome card(
welcome.tsx) now renderpublic/edge0_logo.pnginstead of theSparklesplaceholders - mirrors the macos changeandroid (
4b6640f,6180281)Added adaptive icon (anydpi-v26: antialiased glyph-only foreground at
~58% of canvas, inside the 66% safe zone, over a pure-black
background layer) + legacy mipmaps (mdpi..xxxhdpi, full-bleed
square), wired via
android:iconthe launcher's circle mask clipped the lightning tips; re-cut from
the full-bleed master fixes it
with standard material icons), verified by grep + on-device screenshot
dev-flow fixes pulled in by running the apps (
7d0713f,d317721)src-tauri/from vite's chokidar watcher - coldtauri devbuilds crashed twice withEBUSYwhen Defender lockedfreshly linked artifacts; the tauri CLI already watches
src-tauriitself, and this matches the create-tauri-app template
/.kotlin)