Allow scaling to zero if canary not enabled

[avenski-ecovadis]

Description

Allow scale-to-zero (replicaCount: 0) on the dotnet-core chart without breaking helm upgrade.

Today the HPA template is unconditional (since #158), so setting replicaCount: 0 always fails with:

spec.minReplicas: Invalid value: 0: must be greater than or equal to 1
spec.maxReplicas: Invalid value: 0: must be greater than 0

This is a hard K8s constraint — Resource-metric (CPU/memory) HPAs can never scale to zero, regardless of chart config. #158 made HPA creation unconditional specifically because Flagger's
Canary CRD (autoscalerRef) requires the HPA to exist whenever canary.enabled: true; skipping it broke canary rollouts.

Fix: skip HPA creation only when replicaCount: 0 and canary is disabled — {{- if or .Values.global.canary.enabled (gt (.Values.global.replicaCount | int) 0) }}. Deployment already
renders replicas directly from replicaCount, so with HPA skipped, replicaCount: 0 now suspends the workload cleanly.

Canary + replicaCount: 0 still isn't supported (HPA still forced to exist to satisfy Flagger, still fails K8s validation) — that combination is fundamentally incompatible, not something
the chart can fix.

Chart

Select the chart that you are modifying:

• core
• dotnet-core
• cron-job
• job
• app-reverse-proxy
• pact-broker
• ado-build-agents
• ado-agent-cleaner
• event-worker

Checklist

• Description provided
• Linked issue
• Chart version bumped
• README.md updated with any new values or changes
• Updated template tests in ${CHART}/tests/*.py

[kkubicki-ecovadis]

apporved