Repository navigation
Conversation
added 5 commits
October 30, 2026 18:52
…id cutouts - iOS ScreenCorners fractions; Duo outer hinge 8; Duo inner landscape safe 84/34 - Face ID notch bottomRadius / cited topRadius (X/XS/11 Pro ear 6); uncalibrated ears unset - Android geometry + cutout audit (Pixel 5/9/10 Pro, Fold, S20+/Ultra, 3 XL, …) - Classic honesty (drop unmeasured Pixel 8); validation / verified-preset tests
- Screen + body Figma ξ≈0.6 clip-path (kill PNG white bleed / square chrome) - Face ID notch circular clip-path ears + bottom fillets (no ξ on notch) - Home indicator pill rendered for iOS presets only
- packages/frame/screen-qa Vite page rendering every DEVICES preset - scripts/shot-all-devices.mjs headless screenshots - scripts/audit-non-ios-home-indicator.mjs asserts no HI on non-iOS
- Expect paint width = body + 2·ear and data-notch-curve=circular - Skip right-ear icon budget for right-edge punch holes (centerX ≳ 0.9)
- Reformat iOS/Android presets for oxfmt from main - Regenerate docs/device-pages.md for radius/cutout updates - Drop unused imports / Array constructor lint nits in QA scripts
lbb00
force-pushed
the
fix/cutout-chrome-restore
branch
from
October 30, 2026 10:55
79e5052 to
b5bd587
Compare
lbb00
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screen-fidelity follow-up for device cutouts and chrome. Rebases onto
main(including #42 CI/deps). Keeps profile geometry citeable; paints continuous screen corners and circular Face ID notches; draws the Home Indicator on iOS presets only.What changed
@devicekit/devicesbottomRadius/ citedtopRadius(X/XS/11 Pro ear 6); uncalibrated ears stay unset.@devicekit/frameclip-path(Chromiumcorner-shape: squirclekept as progressive enhancement).clip-pathears + bottom fillets (notch-continuous-path); no Figma ξ on the notch.data-notch-curve=circular, right-edge punch-hole icon budget skip).Screen QA
packages/frame/screen-qaVite harness rendering everyDEVICESpreset.scripts/shot-all-devices.mjs— headless Chrome screenshots of all devices.scripts/audit-non-ios-home-indicator.mjs— asserts no iOS-style HI on non-iOS presets.docs/device-pages.mdfor the profile updates.Test plan
pnpm install --frozen-lockfilepnpm format:checkpnpm run check:device-pagespnpm lint(exit 0; one pre-existing React refs warning inreact/index.tsx)pnpm check-typespnpm test— devices 866, frame 424, scripts 9 — all passpnpm --filter @devicekit/frame demo:buildNotes
origin/main@55b29c5(merge of chore: resolve Dependabot Actions/JS bumps (setup-node, pnpm action, minor, Vitest 5) #42). Workflows pick up setup-node v7.1.0 and pnpm/action-setup v6.1.0.