feat(cli): redesign route output as multi-line indented format#1934
feat(cli): redesign route output as multi-line indented format#1934
route output as multi-line indented format#1934Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 534e9995ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This pull request redesigns the route command output from a wide 13-column table to a more readable multi-line indented format inspired by the ip route command style. The change makes the output more terminal-friendly by eliminating horizontal scrolling and presenting each route entry across multiple lines with clear key-value labeling.
Changes:
- Replaced
RouteTableItem(withtabled::Tabledtrait) withRouteItem(onlyserde::Serialize) to support custom text formatting - Implemented multi-line output format with 2-4 lines per route entry, showing identifier, hostname/version, routing info, and optional latency-first path
- Modified next_hop logic to prefer hostname over IP address for better readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5feede9 to
6945152
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
感觉新的格式也不好看 |
收到,已紧急召开 codex / claude-code / kimi 联席会议讨论解决此问题 |
6945152 to
8eb35f2
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
8eb35f2 to
af2a891
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
af2a891 to
f1b2859
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Replace multi-line text format with table output: - Default: 6 columns (Hostname, IPv4, Via, Hops, Latency, Proxy) - --wide/-w: 8 columns (+ Lat-First, Version) - Rename global --no-trunc to --wide - Proxy column uses newline for multiple items - Lat-First column shows via/hops/latency in 3 lines when different
f1b2859 to
623fa4a
Compare
Summary
easytier-cli routeoutput to usetabledtable format instead of multi-line text--wide/-wglobal option to show extended route informationDefault output (6 columns):
Wide output (
-wflag, 7 columns):Changes
RouteTableItemandRouteTableItemWidestructures usingtabled::Tabledprint_output()function enhanced with wrapping support:table.modify(Rows::new(1..), Width::wrap(terminal_width))for data rows only-v) behavior unchangedBreaking Changes
--no-truncflag renamed to--wide/-w