Add a simple but powerful theming API#7733
Open
javiereguiluz wants to merge 6 commits into
Open
Conversation
Contributor
|
Nice work and approach! Have you considered about DTCG tokens? It's the emerging standard to define design tokens. Awesome tooling with Terrazzo, WP uses it for its admin theme redesign. I built a PHP library to consume them: https://github.com/nlemoine/dtcg-tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the theming work from #7719, #7730 and #7731 with a shadcn-inspired PHP API to configure the design tokens without writing CSS:
<style>in<head>, placed so user CSS still wins over the theme.<style>tag, so this is a security boundary): hex/rgb()/hsl()/oklch()colors,px/remlengths.--ea-primary-foreground) is computed automatically from the primary color's luminance (black or white).It also includes some related fixes and improvements found while testing it:
--bs-gutter-x; everything (including Bootstrap's grid gutter) is now based on spacing tokens, so it scales withspacing().--form-fieldset-spacingvariable, and tighter, consistent gaps between fieldsets.