Remove the ENTITY_FQCN_TO_CRUD_FQCN cache entry, which was written but never read#7716
Merged
javiereguiluz merged 1 commit intoJul 22, 2026
Conversation
…t never read AdminRouteGenerator built and cached a one-to-many entity-to-controllers map on every route generation, but no code reads that cache entry: AdminControllerRegistry derives its own (documented, last-controller-wins) reverse map with array_flip() from the CRUD_FQCN_TO_ENTITY_FQCN entry. Note: this removes the public CacheKey::ENTITY_FQCN_TO_CRUD_FQCN constant.
guillaume-sainthillier
force-pushed
the
remove-unused-entity-fqcn-cache-entry
branch
from
July 13, 2026 07:34
79db6fe to
b784737
Compare
Collaborator
|
Merged! Thanks Guillaume. We usually don't remove public constants like this (we follow Symofny's process of deprecating it first). But, given that this is mostly internal, and nobody should need this in EasyAdmin 5+ versions, I just added a short entry in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdminRouteGenerator built and cached a one-to-many entity-to-controllers
map on every route generation, but no code reads that cache entry:
AdminControllerRegistry derives its own (documented, last-controller-wins)
reverse map with array_flip() from the CRUD_FQCN_TO_ENTITY_FQCN entry.
Note: this removes the public CacheKey::ENTITY_FQCN_TO_CRUD_FQCN constant.