Don't lose the original exception when the fallback AdminContext creation fails#7715
Merged
javiereguiluz merged 1 commit intoJul 22, 2026
Conversation
…tion fails When context creation fails (e.g. entity not found), the subscriber builds a fallback context without the entity to render the error page with the EasyAdmin layout. That second AdminContextFactory::create() call runs user-defined code (configureActions(), action extensions) against a context whose entity is null, so it can throw as well. Without a guard, that secondary error replaced the original exception and the stripped entityId/id/_route_params attributes were never restored. The fallback creation is now wrapped in try/finally: the original exception is always rethrown and the attributes are always restored.
guillaume-sainthillier
force-pushed
the
preserve-original-exception-in-admin-router-subscriber
branch
from
July 13, 2026 07:33
805b27e to
e6287aa
Compare
Collaborator
|
Thank you Guillaume. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When context creation fails (e.g. entity not found), the subscriber
builds a fallback context without the entity to render the error page
with the EasyAdmin layout. That second AdminContextFactory::create()
call runs user-defined code (configureActions(), action extensions)
against a context whose entity is null, so it can throw as well.
Without a guard, that secondary error replaced the original exception
and the stripped entityId/id/_route_params attributes were never
restored. The fallback creation is now wrapped in try/finally: the
original exception is always rethrown and the attributes are always
restored.