Fix TypeError when calling Crud::setFilters(null)#7712
Merged
javiereguiluz merged 1 commit intoJul 22, 2026
Conversation
The method signature accepts null but forwarded the value unchanged to CrudDto::setFiltersConfig(), whose parameter is not nullable. Null now means 'no filters' and is normalized to an empty FilterConfigDto.
guillaume-sainthillier
force-pushed
the
fix-crud-set-filters-null
branch
from
July 13, 2026 07:33
5f941a0 to
d804925
Compare
Collaborator
|
Thanks for fixing this bug Guillaume. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method signature accepts null but forwarded the value unchanged to
CrudDto::setFiltersConfig(), whose parameter is not nullable. Null now
means 'no filters' and is normalized to an empty FilterConfigDto.