Mark immutable promoted properties as readonly#7708
Merged
javiereguiluz merged 1 commit intoJul 21, 2026
Merged
Conversation
Also removes the one redundant 'readonly' modifier in ActionFactory, which is already a readonly class.
guillaume-sainthillier
force-pushed
the
mark-promoted-properties-readonly
branch
from
July 13, 2026 07:33
77358fa to
1d72551
Compare
javiereguiluz
left a comment
javiereguiluz
left a comment
Collaborator
There was a problem hiding this comment.
Another nice change. Thanks Guillaume!
| { | ||
| public function __construct( | ||
| private EntityTranslationIdGeneratorInterface $entityTranslationIdGenerator, | ||
| private readonly EntityTranslationIdGeneratorInterface $entityTranslationIdGenerator, |
Collaborator
There was a problem hiding this comment.
I marked the entire CommonConfigurator class as readonly
| { | ||
| public function __construct( | ||
| private AdminUrlGeneratorInterface $adminUrlGenerator, | ||
| private readonly AdminUrlGeneratorInterface $adminUrlGenerator, |
Collaborator
There was a problem hiding this comment.
I marked the entire EntityConfigurator class as readonly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes the one redundant 'readonly' modifier in ActionFactory,
which is already a readonly class.