Skip to content

Server & Workiversaries - #2

Open
ashtonmeuser wants to merge 7 commits into
masterfrom
task-0001-node-server
Open

ashtonmeuser wants to merge 7 commits into
masterfrom
task-0001-node-server

Conversation

@ashtonmeuser

Copy link
Copy Markdown

Download from Google Sheets
Add server with /month and /today endpoints
Calculate workiversaries from Sheets data

Comment thread package.json Outdated
"test": "echo \"Error: no test specified\" && exit 1"
},
"dependencies": {
"dayjs": "^1.8.21",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lock

Comment thread server.js Outdated
reportingDates, employeeFromRow, workiversariesByDates, workiversariesByMonth,
} = require('./workiversaries.js');

const sheetId = '1aJOtfVhFacpWEpKifFzKegI0x49_rqbhiR0o3fPwneg';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't be comitted

Comment thread server.js Outdated
@@ -0,0 +1,32 @@
const express = require('express');
const { getSheetContent } = require('./sheets.js');
const {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look into es6 imports

@mmumby mmumby left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mmumby

mmumby commented Mar 13, 2020

Copy link
Copy Markdown

For some reason, I only saw one of Adams comments before approving. Let's add the sheet Id to an env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants