fix(evolution): constrain pending skill path operations#89
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill_namewas joined directly under_evolved/_pending.skilllite-evolution, applies it to mutating operations and desktopSKILL.mdreads, and keeps valid pending skill confirm/reject behavior unchanged...movement attempts are rejected while out-of-scope directories survive.Task Linkage
TASK-2026-067tasks/TASK-2026-067-pending-skill-path-safety/Injected Specs
spec/architecture-boundaries.md(reviewed; no boundary changes)spec/security-nonnegotiables.md(security fix)spec/testing-policy.md(Rust code change)spec/docs-sync.md(reviewed; no docs needed because no user-facing command/env/policy wording changed)Validation Evidence
cargo test -p skilllite-evolution pending_skill -- --nocapturecargo test -p skilllite-evolutioncargo test -p skilllite-commandscargo fmt --checkcargo clippy --all-targets -- -D warningscargo testpython3 scripts/validate_tasks.py3 passed; 0 failed; 94 filtered outskilllite-evolution:97 passed; 0 failedskilllite-commands:23 passed; 0 failedcargo test: passedTask validation passed (67 task directories checked)AGENTS.md, then validation passed.Regression Scope
skilllite evolution confirm|rejectskilllite-evolutionpending skill filesystem operationsDocs Sync (EN/ZH)
Review Checklist
tasks/TASK-2026-067-pending-skill-path-safety/TASK.mdsatisfiedtasks/TASK-2026-067-pending-skill-path-safety/STATUS.mdupdated with latest progresstasks/TASK-2026-067-pending-skill-path-safety/REVIEW.mdincludes merge readiness decisiontasks/board.mdstatus is up to date