Skip to content

Fix desktop evolution workspace scoping#88

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/critical-bug-investigation-8968
Draft

Fix desktop evolution workspace scoping#88
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/critical-bug-investigation-8968

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor Bot commented Jun 2, 2026

Summary

  • Fixes a critical desktop evolution state-splitting bug where chat/evolution subprocesses could use different effective SKILLLITE_WORKSPACE values, causing manual evolution to see an empty DB and user-authorized capability evolution to silently force-run against the wrong DB.
  • Uses the explicit desktop-selected workspace as the child process data root, propagates --workspace into background authorization runs, and aligns evolution run skill output with the desktop skills/-first resolver while preserving .skills/ legacy fallback.

Task Linkage

  • Task ID: TASK-2026-067
  • Task folder: tasks/TASK-2026-067-desktop-evolution-workspace-scope/

Injected Specs

  • spec/architecture-boundaries.md (if architecture/layering changed)
  • spec/security-nonnegotiables.md (if sandbox/security changed)
  • spec/testing-policy.md (required for any code change)
  • spec/docs-sync.md (if behavior/docs/env/commands changed)

Validation Evidence

  • Commands executed:
    • rustup update stable && rustup default stable
    • npm ci && npm run build in crates/skilllite-assistant
    • cargo fmt --check
    • cargo clippy --all-targets -- -D warnings
    • cargo test
    • cargo test -p skilllite
    • cargo test -p skilllite-commands
    • cargo test --manifest-path crates/skilllite-assistant/src-tauri/Cargo.toml explicit_workspace_env_overrides_dotenv_workspace
    • cargo test --manifest-path crates/skilllite-assistant/src-tauri/Cargo.toml background_run_args_include_explicit_workspace
    • python3 scripts/validate_tasks.py
  • Key results:
    • cargo test -p skilllite-commands: 23 passed; 0 failed.
    • cargo test -p skilllite: CLI unit/integration suites passed, including e2e_minimal.
    • cargo clippy --all-targets -- -D warnings: finished successfully.
    • cargo test: workspace tests and doctests completed successfully.
    • Assistant focused tests: each filtered regression test passed after installing Linux Tauri build dependencies and generating dist.
    • python3 scripts/validate_tasks.py: Task validation passed (67 task directories checked).

Regression Scope

  • Areas likely affected:
    • crates/skilllite-assistant/src-tauri/src/skilllite_bridge/chat.rs
    • crates/skilllite-assistant/src-tauri/src/skilllite_bridge/evolution_cli.rs
    • crates/skilllite-assistant/src-tauri/src/skilllite_bridge/integrations/evolution_ui/authorize.rs
    • crates/skilllite-assistant/src-tauri/src/skilllite_bridge/paths.rs
    • crates/skilllite-commands/src/evolution.rs
  • Explicit non-goals:
    • Runtime provisioning progress streaming.
    • Skills-list fallback/error policy.
    • Evolution scoring, LLM behavior, or sandbox policy changes.

Docs Sync (EN/ZH)

  • Not needed
  • Updated EN + ZH docs
  • Files:
    • N/A: no public flags, documented commands, or architecture contracts changed; this aligns behavior with the existing explicit workspace contract.

Review Checklist

  • Acceptance criteria in tasks/.../TASK.md satisfied (or explicitly deferred)
  • tasks/.../STATUS.md updated with latest progress
  • tasks/.../REVIEW.md includes merge readiness decision
  • tasks/board.md status is up to date
Open in Web View Automation 

cursoragent and others added 2 commits June 2, 2026 11:10
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant