Keep Orders inventory route-owned and clarify manual email sending - #209
Merged
Conversation
Remove the Orders-only standalone inventory assignment path while preserving Route Group inventory synchronization and detail access. Explain every manual email send blocker with standard checkboxes and executable readiness tests. Constraint: Route-linked inventory remains owned and synchronized by Route Group operations; real customer email sends are external side effects. Rejected: Auto-selecting every eligible email recipient | manual sends must retain explicit recipient selection. Confidence: high Scope-risk: moderate Directive: Do not reintroduce standalone Inventory creation from Orders; preserve explicit recipient selection and all server confirmation flags. Tested: Shopify app 527 tests; targeted app 220 tests; delivery API inventory/email 95 tests; lint; typecheck; production build; public URL guard; Shopify component validation. Not-tested: Signed-in embedded browser interaction and a real email-provider delivery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Safety