Skip to content

Require an explicit route group copy mode - #208

Merged
OziinG merged 1 commit into
mainfrom
codex/cc-263-route-group-copy-modes-app
Aug 20, 2026
Merged

Require an explicit route group copy mode#208
OziinG merged 1 commit into
mainfrom
codex/cc-263-route-group-copy-modes-app

Conversation

@OziinG

@OziinG OziinG commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the client-side GET-detail then generic-create copy flow with the atomic server copy command
  • require an explicit no-default choice between 실제 주문으로 복사 and 가상 주문으로 독립 복사
  • preserve success navigation while keeping server errors in an accessible native dialog
  • use a fresh Shopify session token for the submit and prevent duplicate submissions

Contract

  • sends only { mode, expectedUpdatedAt } to POST /admin/route-groups/:routeGroupId/copies
  • maps the stable CUSTOM_ORDER_REFERENCE_COPY_NOT_ALLOWED response
  • adds no Shopify mutation

Validation

  • targeted 84 tests; full app 545/545
  • lint, typecheck, production build
  • public URL guard and git diff --check
  • Shopify UI validator revision 3
  • independent code review approved accessibility and state transitions

Dependency and tracking

Not performed

  • live copy execution against the unmerged server endpoint
  • merge or deploy

@OziinG
Require safe ownership semantics for route group copies
6ba6463 
Move copy execution behind the delivery server atomic command and require merchants to choose reference or virtual ownership before submission.

Constraint: Shopify must not reconstruct copy payloads or mutate upstream commerce data.
Rejected: GET detail followed by generic group create | reused CUSTOM order IDs and allowed cross-group cascade damage.
Confidence: high
Scope-risk: moderate
Directive: Merge only after the route-server copy command and ownership migration PR is available.
Tested: targeted 84 tests; full app 545 tests; lint; typecheck; production build; public URL guard; Polaris validator; git diff --check.
Not-tested: live copy execution against the unmerged route-server endpoint.
@OziinG OziinG linked an issue Aug 20, 2026 that may be closed by this pull request
Require explicit REFERENCE or VIRTUAL mode when copying route groups #207
Closed
This was referenced Aug 20, 2026
Closed
Closed
@OziinG
OziinG marked this pull request as ready for review August 20, 2026 06:05
@OziinG
OziinG merged commit 5006eec into main Aug 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Require explicit REFERENCE or VIRTUAL mode when copying route groups

1 participant

@OziinG