Allow skipping checks of certain tracer variables#85
Merged
Conversation
There are some tracer fields that are not yet implemented properly. Allow skipping these fields when we perform tracer checks.
nusbaume
requested changes
Jul 9, 2026
nusbaume
left a comment
nusbaume
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this feature @billsacks! I have some questions and suggestions, but nothing that I feel super-strongly about (in case you disagree).
Member
Author
|
Thank you for your review, @nusbaume ! You raised some good points. I have either made changes or replied with comments as to why I'm (tentatively) not making changes for each of your points. I'm happy to hear any more dissenting opinions on any of this. |
nusbaume
approved these changes
Jul 9, 2026
nusbaume
left a comment
nusbaume
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the responses @billsacks! Everything looks good to me now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some tracer fields that are not yet implemented properly. Allow skipping these fields when we perform tracer checks.
See billsacks/CMEPS@98cefc20e for the CMEPS change that uses this new feature. I'd like to get this share code change reviewed and merged since it's a prerequisite for the branch with that CMEPS change.
The changes here were written by Claude with my careful review.