Skip to content

ci: the release pull request says which release it is - #47

Merged
ExtraToast merged 1 commit into
mainfrom
chore/release-please-title
Sep 16, 2026
Merged

ExtraToast merged 1 commit into
mainfrom
chore/release-please-title

Conversation

@ExtraToast

Copy link
Copy Markdown
Contributor

Refs ESA-Blueshell/website#1243.

Why

Every release pull request here is titled chore: release main. The version it would publish is not in the title, so one release pull request reads exactly like the last one — in a list, in a notification, and in the merge commit it becomes.

What this achieves

chore(main): release X.Y.Z, which is what JorisJonkers-dev/deploy-kit, nix-config and api-contract-checks already say.

How

Two keys go.

separate-pull-requests: false was the cause. In release-please's manifest.ts the default is Object.keys(repositoryConfig).length === 1 — already true for a single-package manifest like this one. Setting it to false turns the merge plugin on regardless, and the merge plugin reads group-pull-request-title-pattern, not pull-request-title-pattern. Its default is chore: release ${branch}, which is where main comes from.

pull-request-title-pattern: "chore: release ${version}" goes with it: unread while the merge plugin was on, and unnecessary once it is off, because the built-in default is chore${scope}: release${component} ${version} — the same thing plus the branch scope the rest of the estate shows.

Not in scope

The branch name. release-please--branches--main is named in release.yml here and in five workflow conditions in the two client repositories, so it must not move — and it does not: with package-name unset, a single-package release keeps BranchName.ofTargetBranch. nix-config and api-contract-checks are the evidence, with the right title on that same branch.

Verification

The configuration parses as JSON and keeps its schema reference. The next release pull request is where the title is visible; the open one carries the autorelease: pending label, so release-please updates it in place rather than opening a second.

@ExtraToast ExtraToast self-assigned this Sep 16, 2026
@ExtraToast ExtraToast changed the title ci(release): the release pull request says which release it is ci: the release pull request says which release it is Sep 16, 2026
Every release pull request here is titled `chore: release main`, because
`separate-pull-requests: false` turns on the merge plugin — which a
single-package manifest does not need, and which reads
`group-pull-request-title-pattern`, not the `pull-request-title-pattern` this
file sets. That default is `chore: release ${branch}`, so the configured
request for the version was never consulted.

Both keys go. The built-in default, `chore${scope}: release${component}
${version}`, is what the rest of the estate shows: `chore(main): release
0.6.0`.

The head branch does not move — five workflow conditions name it — because a
single-package release with no `package-name` keeps
`BranchName.ofTargetBranch`.
@ExtraToast
ExtraToast force-pushed the chore/release-please-title branch from 30daa86 to 3c3c71e Compare September 16, 2026 18:17
@ExtraToast
ExtraToast merged commit d52122b into main Sep 16, 2026
6 checks passed
@ExtraToast
ExtraToast deleted the chore/release-please-title branch September 16, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant