Conversation
C's `_Bool` type was indiscriminately compiled to `i1` previously. However, this creates invalid IR when using a `_Bool` array as input. Since C defines a bool to always be of byte size, all `memref` operations (after conversion) expect a `memref` of type `i8` rather than `i1`. This PR for now does the easy and working change of adhering to C's memory representation of using a byte per bool when used in an array (aka memory).
Member
|
What if we intend to describe an array of bits? Does |
Collaborator
Author
I don't think it'd work right now due to how Clang compiles these to be padded to full bytes: That said, I don't think there is anything in the C standard that prevents us from doing so (unlike for |
Jiahui17
reviewed
Feb 27, 2026
Jiahui17
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C's
_Booltype was indiscriminately compiled toi1previously. However, this creates invalid IR when using a_Boolarray as input. Since C defines a bool to always be of byte size, allmemrefoperations (after conversion) expect amemrefof typei8rather thani1.This PR for now does the easy and working change of adhering to C's memory representation of using a byte per bool when used in an array (aka memory).