Conversation
Remove the export and citations templates from the record detail sidebar to simplify the UI layout.
|
There was a problem hiding this comment.
Pull request overview
Updates the record detail permalink area to distinguish between the record’s primary persistent identifier and the RIV-only link, with corresponding styling and translation updates, and adjusts the record detail layout/sidebar configuration.
Changes:
- Reworks the permalink UI into two Semantic UI segments (primary persistent identifier vs. RIV-only link) with copy buttons.
- Updates record detail header layout classes and adds LESS styling for the new segments.
- Regenerates translation catalogs for new/updated strings and removes citation/export sidebar templates from the detail sidebar config.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/datasets/templates/semantic-ui/datasets/record_detail/permalink.html | Replaces the old permalink header with two labeled identifier sections and new copy buttons. |
| ui/datasets/templates/semantic-ui/datasets/record_detail/main.html | Adjusts grid/column classes and wraps the permalink include in a dedicated container. |
| assets/less/site/elements/segment.overrides | Adds styling rules for the new identifier segments and headers. |
| invenio.cfg | Removes citation/export sidebar templates from APP_RDM_DETAIL_SIDE_BAR_TEMPLATES. |
| translations/messages.pot | Regenerates the POT with new strings and updated source references. |
| translations/en/LC_MESSAGES/messages.po | Updates English catalog to match the regenerated POT and new strings. |
| translations/cs/LC_MESSAGES/messages.po | Updates Czech catalog to match the regenerated POT and new strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <span class="identifier-link" data-testid="record-detail-title-persistent-identifier"> | ||
| <strong>{{ persistent_url | trim }}</strong> | ||
| <ClipboardCopyButton className="ml-5" copyText={{persistent_url}} /> |
There was a problem hiding this comment.
persistent_url can be missing/None (other templates guard it with {% if persistent_url %}), but here it’s always rendered and passed into ClipboardCopyButton. This can result in an empty/"None" identifier and a copy button with an invalid value. Wrap the primary identifier segment (or at least the <strong> + copy button) in an if persistent_url guard, and consider falling back to record_permalink if that’s the desired behavior when persistent_url is absent.
| <span class="identifier-link" data-testid="record-detail-title-persistent-identifier"> | |
| <strong>{{ persistent_url | trim }}</strong> | |
| <ClipboardCopyButton className="ml-5" copyText={{persistent_url}} /> | |
| <span class="identifier-link" data-testid="record-detail-title-persistent-identifier"> | |
| {% if persistent_url %} | |
| <strong>{{ persistent_url | trim }}</strong> | |
| <ClipboardCopyButton className="ml-5" copyText={{persistent_url}} /> | |
| {% else %} | |
| <strong>{{ record_permalink | trim }}</strong> | |
| <ClipboardCopyButton className="ml-5" copyText={{record_permalink}} /> | |
| {% endif %} |
No description provided.